[CLOSED] Unit Test Failure: ViewCommandHandlers should restore the font size in both editor and inline editor

[core-ai-bot]

Issue by redmunds
Monday Mar 17, 2014 at 15:48 GMT
Originally opened as adobe/brackets#7215

---

I used git bisect to isolate it to commit adobe/brackets@25ee232

@TomMalbran
cc@RaymondLim

should restore the font size in both editor and inline editor

Error: Expected 15 to be 17.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBe (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/spec/ViewCommandHandlers-test.js:125:60)
    at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at jasmine.Queue.start (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1795:8)
    at jasmine.Spec.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2122:14)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.Spec.finish (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2096:5)

Error: Expected 15 to be 17.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBe (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/spec/ViewCommandHandlers-test.js:126:60)
    at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at jasmine.Queue.start (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1795:8)
    at jasmine.Spec.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2122:14)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.Spec.finish (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2096:5)

[core-ai-bot]

Comment by RaymondLim
Monday Mar 17, 2014 at 16:50 GMT

---

I can't reproduce it at first. But after I increase font size in main editor, then I can reproduce it.

[core-ai-bot]

Comment by TomMalbran
Monday Mar 17, 2014 at 18:24 GMT

---

It should be fixed by adobe/brackets#7163, if we swap the view state too.

[core-ai-bot]

Comment by RaymondLim
Monday Mar 17, 2014 at 18:37 GMT

---

@TomMalbran For some reason, #7163 does not fix this.

[core-ai-bot]

Comment by TomMalbran
Monday Mar 17, 2014 at 18:40 GMT

---

@RaymondLim Is not implemented in that PR yet. I am talking about this comments: adobe/brackets#7163 (comment). If that gets implemented, it should probably fix this, since then the window would open with the default font-size, and not the increased one, which is what the test assumes in the first place.

[core-ai-bot]

Comment by dangoor
Tuesday Mar 18, 2014 at 13:36 GMT

---

Yes, it is likely that I will be fixing this too.

[core-ai-bot]

Comment by dangoor
Wednesday Mar 19, 2014 at 15:25 GMT

---

I have confirmed that #7163 fixes this.

[core-ai-bot]

Comment by redmunds
Thursday Mar 20, 2014 at 19:29 GMT

---

Confirmed. Closing.