[CLOSED] Fix a case when extension less file is importing other less files

[core-ai-bot]

Issue by zaggino
Tuesday Mar 18, 2014 at 12:22 GMT
Originally opened as adobe/brackets#7230

---

I wanted to split less file my extension is using into more files, but loading failed when using valid import directives. Through debugging, I found out that some properties of file info were not filled as it should.

These are the values for file brackets.less:

currentDirectory: "file:///D:/Program%20Files/Brackets/dev/src/styles/"
entryPath:        "file:///D:/Program%20Files/Brackets/dev/src/styles/"
filename:         "file:///D:/Program%20Files/Brackets/dev/src/styles/brackets.less"
relativeUrls:     undefined
rootFilename:     "file:///D:/Program%20Files/Brackets/dev/src/styles/brackets.less"
rootpath:         "file:///D:/Program%20Files/Brackets/dev/src/styles/"

And these are the original values calculated for brackets-git.less:

currentDirectory: ""
entryPath:        ""
filename:         "brackets-git.less"
relativeUrls:     undefined
rootFilename:     "brackets-git.less"
rootpath:         "file:///C:/Users/Zaggi/AppData/Roaming/Brackets/extensions/user/zaggino.brackets-git/less/"

The fix makes fileInfo look the same way as in the brackets.less case and all references are loaded correctly.

---

zaggino included the following code: https://github.com/adobe/brackets/pull/7230/commits

[core-ai-bot]

Comment by zaggino
Tuesday Mar 18, 2014 at 12:24 GMT

---

Btw, is there a reason Brackets is still using less 1.4.2 when latest version is 1.7.0 ? The fix works for both versions and I didn't find any ill effects when upgrading to 1.7.0.

[core-ai-bot]

Comment by le717
Tuesday Mar 18, 2014 at 14:11 GMT

---

@zaggino Discussion about updating Less to 1.7.0 is in #6730.

[core-ai-bot]

Comment by zaggino
Tuesday Mar 18, 2014 at 19:24 GMT

---

Thanks@le717, I thought I've seen it somewhere but I wasn't sure. Anyway it's not included in this PR.

[core-ai-bot]

Comment by redmunds
Wednesday Mar 19, 2014 at 00:50 GMT

---

There's an Extension Utils unit test failing:

should attach LESS style sheets

Error: Expected '/* basic.less */
#project-title {
  font-size: 66px;
}
' to be '/* basic.less */
#project-title {
  font-weight: 800;
}
#project-title {
  font-size: 66px;
}
'.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBe (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/spec/ExtensionUtils-test.js:134:40)
    at jasmine.Block.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.WaitsForBlock.execute (file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2322:5)
    at file:///C:/Users/redmunds/dev/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2336:12

[core-ai-bot]

Comment by zaggino
Wednesday Mar 19, 2014 at 01:30 GMT

---

@redmunds It seems my issue only relates to absolute url's. Do we have any function like FileSystem.isAbsolutePath which checks if url starts with (http|https|file):// ?

[core-ai-bot]

Comment by zaggino
Wednesday Mar 19, 2014 at 01:34 GMT

---

I'd probably put the isAbsoluteUrl function into StringUtils.js and use that instead of file:// if there's not a better way.

[core-ai-bot]

Comment by redmunds
Wednesday Mar 19, 2014 at 01:35 GMT

---

In thirdparty/path-utils/path-utils.js there's an isAbsoluteUrl function.

[core-ai-bot]

Comment by zaggino
Wednesday Mar 19, 2014 at 02:03 GMT

---

Review again please@redmunds

[core-ai-bot]

Comment by redmunds
Wednesday Mar 19, 2014 at 03:08 GMT

---

Looks good. Just 1 minor comment.

[core-ai-bot]

Comment by zaggino
Wednesday Mar 19, 2014 at 03:22 GMT

---

Done, comments removed.

[core-ai-bot]

Comment by redmunds
Wednesday Mar 19, 2014 at 03:32 GMT

---

Looks good. Thanks for unit test! Merging.