[CLOSED] Moved .notification icon in Extension Manager dialog

[core-ai-bot]

Issue by logarytm
Friday Mar 21, 2014 at 19:02 GMT
Originally opened as adobe/brackets#7287

---

I've rearranged the .notification item (installed extensions number) badge so that clicking it switches to the Installed Extensions tab. Appropriate .less files also got modified in order to get the icon themed properly. This aims to fix bug #7280.

---

logarytm included the following code: https://github.com/adobe/brackets/pull/7287/commits

[core-ai-bot]

Comment by peterflynn
Friday Mar 21, 2014 at 22:13 GMT

---

@winek You have to sign the Contributor License Agreement before we can merge your first contribution (this is par for the course in most open source projects).

[core-ai-bot]

Comment by logarytm
Saturday Mar 22, 2014 at 08:19 GMT

---

Signed, is there any way to rerun the build?

[core-ai-bot]

Comment by redmunds
Saturday Mar 22, 2014 at 15:34 GMT

---

To rerun the build, click on the "Details" link next to "Failed — The Travis CI build failed" to go to the Travis page, then click the button in upper right that looks like a refresh button (tooltip says "Restart Build").

[core-ai-bot]

Comment by logarytm
Saturday Mar 22, 2014 at 15:42 GMT

---

There is no "Restart Build" button. Perhaps because I don't have write access to the adobe/brackets repository?

[core-ai-bot]

Comment by redmunds
Saturday Mar 22, 2014 at 16:41 GMT

---

I just restarted the build. For future reference, make sure you're logged in.

[core-ai-bot]

Comment by MarcelGerber
Sunday Mar 23, 2014 at 02:27 GMT

---

@redmunds The button is only shown if you have write access to the repo - so only commiters can do that.

[core-ai-bot]

Comment by redmunds
Sunday Mar 23, 2014 at 16:28 GMT

---

@SAPlayer OK. Seems like the person who submitted the pull request should also be able do that.

[core-ai-bot]

Comment by MarcelGerber
Sunday Mar 23, 2014 at 19:36 GMT

---

Nope, you need to be collaborator of adobe/brackets.

[core-ai-bot]

Comment by pthiess
Monday Mar 24, 2014 at 17:28 GMT

---

@lkcampbell Could you please take look - Thanks :)

[core-ai-bot]

Comment by lkcampbell
Tuesday Mar 25, 2014 at 03:07 GMT

---

Looks good. Merging.