[CLOSED] Check for extensions updates

[core-ai-bot]

Issue by zaggino
Tuesday Mar 25, 2014 at 22:10 GMT
Originally opened as adobe/brackets#7330

---

As mentioned here adobe/brackets#6723

Ping@lkcampbell@larz0

P.S.: this is not a complete thing but I wanted to get it moving at least a bit (and design is ugly because I don't have a software to work with SVG :)) Feel free to push into this branch.

---

zaggino included the following code: https://github.com/adobe/brackets/pull/7330/commits

[core-ai-bot]

Comment by larz0
Tuesday Mar 25, 2014 at 23:08 GMT

---

Thanks@zaggino! I played with it, trying to make the number smaller so it won't cover the extension icon but made the number hard to read. I think we discussed that's it's okay to not include the number. Thoughts?

[core-ai-bot]

Comment by zaggino
Tuesday Mar 25, 2014 at 23:52 GMT

---

Yes, we can remove the number completely. I think@lkcampbell mentioned just making the icon green and that's fine with me, but I didn't really know how to do it fast and didn't want to spent half a day with SVG thingy now :)

[core-ai-bot]

Comment by larz0
Wednesday Mar 26, 2014 at 00:09 GMT

---

We can just use span like what@peterflynn suggested originally like this (ignore font-size: 0, we should just remove the text):

[core-ai-bot]

Comment by larz0
Wednesday Mar 26, 2014 at 00:10 GMT

---

It'll look like this:

[core-ai-bot]

Comment by zaggino
Wednesday Mar 26, 2014 at 01:01 GMT

---

@Larz0 done ;-)

[core-ai-bot]

Comment by zaggino
Wednesday Mar 26, 2014 at 01:05 GMT

---

I have now realized that update check is done every time someone closes and opens the Brackets... Not only my new update check for extension but also the old check for new Sprint version... this is probably spamming the server? Ping@TomMalbran to clarify.

[core-ai-bot]

Comment by larz0
Wednesday Mar 26, 2014 at 01:06 GMT

---

I accidentally hit close!

Hopefully this can be merged pretty quickly.

[core-ai-bot]

Comment by zaggino
Wednesday Mar 26, 2014 at 01:08 GMT

---

Probably not so fast, I see these lines in master https://github.com/adobe/brackets/blob/master/src/brackets.js#L295-L305 as problematic. I don't think it's a good idea to do requests everytime Brackets are started - I do that quite a lot.

[core-ai-bot]

Comment by zaggino
Wednesday Mar 26, 2014 at 01:11 GMT

---

Also Travis says zaggino has NOT submitted the contributor license agreement ... what sorcery is this? 😕

[core-ai-bot]

Comment by larz0
Wednesday Mar 26, 2014 at 01:18 GMT

---

Hmm I think I saw an email about that from@redmunds.

[core-ai-bot]

Comment by TomMalbran
Wednesday Mar 26, 2014 at 01:31 GMT

---

@zaggino According to issue #6723 the idea was to call it every 24 hours, so it probably shouldn't call it on every launch. So you save the time you get an update and on you just start the timeout on every launch using that time. It should also get updated every time you open the registry and when you update extensions. In this case we should reset the timer. And finally, it might be a good idea to get the updates on the first launch after a Brackets update.

The Brackets updates and the Registry live on different servers and while the Brackets update request might be short, the registry might be a lot longer. So it should use a lot less bandwidth to call the brackets update than the registry. So it might make sense that one resets on every launch but the other one doesn't.

[core-ai-bot]

Comment by TomMalbran
Wednesday Mar 26, 2014 at 01:40 GMT

---

It might also be nice to add a new API to the registry to retrieve the data for a list of extensions, so that we don't need to get every single extension when only have a few installed. But that might be for another PR.

[core-ai-bot]

Comment by zaggino
Wednesday Mar 26, 2014 at 02:28 GMT

---

Ah, it actually does check for the 24 hours, but much more deeper in the code, I'll try to rewrite it a bit.

[core-ai-bot]

Comment by zaggino
Wednesday Mar 26, 2014 at 03:16 GMT

---

This works better now - check at most once a day + if extension is uninstalled or updated, do not show notification for it.

[core-ai-bot]

Comment by redmunds
Wednesday Mar 26, 2014 at 03:32 GMT

---

zaggino has NOT submitted the contributor license agreement

There's a bug in our CLA check script where all checks are failing. We're working on it.