[CLOSED] Tweak Quick Edit error strings & update docs

[core-ai-bot]

Issue by peterflynn
Saturday Mar 29, 2014 at 00:39 GMT
Originally opened as adobe/brackets#7349

---

• Tweak Quick Edit error/feedback strings for clarity
• Fix comments to reflect Quick Edit error related API changes
• Fix outdated FileSyncManager docs (unrelated to the two above, but someone on IRC was just expressing confusion about this today so I figured I'd update this too)

@redmunds, would you be able to review?
CC@njx in case of feedback about the string changes

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/7349/commits

[core-ai-bot]

Comment by redmunds
Saturday Mar 29, 2014 at 03:11 GMT

---

Thanks for reviewing these strings. The changes all look like improvements, except maybe the 1 case I noted. I won't be around to merge this change.

[core-ai-bot]

Comment by peterflynn
Wednesday Apr 02, 2014 at 21:24 GMT

---

@njx /@TomMalbran changes pushed. Since@redmunds isn't around for re-review, can one of you vouch for this & merge?

(btw, the diff in the last commit will look cleaner with ?w=1 in the URL)

[core-ai-bot]

Comment by njx
Wednesday Apr 02, 2014 at 21:42 GMT

---

Actually@JeffryBooher is the assigned reviewer - since he looked at it before, seems like he should finalize it.

[core-ai-bot]

Comment by JeffryBooher
Thursday Apr 03, 2014 at 00:21 GMT

---

Feels like https://trello.com/c/YEd0m9Il should be higher on the backlog now. I really want to invoke the color picker before typing anything now...

[core-ai-bot]

Comment by JeffryBooher
Thursday Apr 03, 2014 at 00:51 GMT

---

done with final review. just the 2 things to consider and this should be good to go.

correction: just the 1 thing I guess. It's not a big deal. LMK if you think it's too much. In general some of the constants are a little misleading such as "CLASS_NOT_FOUND" when we display "incomplete class attribute". Seems that the 2 should agree.

[core-ai-bot]

Comment by JeffryBooher
Thursday Apr 03, 2014 at 01:08 GMT

---

I tested this and compared it to sprint 27 and it's much more friendly. I tested a few other scenarios as well and it feels pretty solid and it's a low-impact change. I'm ready to merge this if you don't want to fix that one comment I mentioned let me know and I will merge it.

[core-ai-bot]

Comment by JeffryBooher
Thursday Apr 03, 2014 at 01:08 GMT

---

@peterflynn

[core-ai-bot]

Comment by peterflynn
Thursday Apr 03, 2014 at 05:27 GMT

---

@JeffryBooher I think it's probably ok as is -- it's the same constant name used in the original PR that was already merged, and it didn't closely match what the user-visible string said back then either.

Re the other comments above, just to note: most of that code hasn't changed in this diff, it's just been indented. If you add ?w=1 to the end of the URL when viewing the diff it should highlight the actual code changes more clearly.

[core-ai-bot]

Comment by JeffryBooher
Thursday Apr 03, 2014 at 05:31 GMT

---

wow@peterflynn where do you find this stuff :) that works wonderfully! Thanks for the tips on github.

[core-ai-bot]

Comment by JeffryBooher
Thursday Apr 03, 2014 at 05:32 GMT

---

@peterflynn do you want to change the comment mentioned above?

[core-ai-bot]

Comment by JeffryBooher
Thursday Apr 03, 2014 at 21:45 GMT

---

looks good. Merging.