[CLOSED] Only kick off project pref loading when the project changes

[core-ai-bot]

Issue by dangoor
Tuesday Apr 01, 2014 at 13:40 GMT
Originally opened as adobe/brackets#7371

---

This is a fix for #7250. What was happening is that there was a file tree refresh occurring and that was causing the PreferencesManager._setCurrentEditingFile in _loadProject to fire. The purpose of that call is to start the loading of project-level prefs, but in this case we weren't actually loading a new project and the result was that the preferences context for editing was being set incorrectly.

---

dangoor included the following code: https://github.com/adobe/brackets/pull/7371/commits

[core-ai-bot]

Comment by peterflynn
Tuesday Apr 01, 2014 at 17:21 GMT

---

@dangoor Do we understand why setting the 'current file' back to the project root was resulting in incorrect JSLint options? The "jslint.options" in our project file isn't path specific, so it seems like any path in the project should yield the same options settings...

[core-ai-bot]

Comment by dangoor
Tuesday Apr 01, 2014 at 19:42 GMT

---

@peterflynn Good question. It turns out that the project scope was being excluded when the project root was the same as the "current editing file". I just pushed a change that makes it so that project scope is also included in that case.

The first fix is still a valid improvement, because if there was a path-scoped preference it would improperly not be applied if _loadProject was called when a new project wasn't actually being loaded.

[core-ai-bot]

Comment by peterflynn
Tuesday Apr 01, 2014 at 20:29 GMT

---

Makes sense -- fixes look good to me!

[core-ai-bot]

Comment by dangoor
Wednesday Apr 02, 2014 at 01:17 GMT

---

@bchintx Peter's cool with this, but you're the reviewer of record. Want to take a look?

[core-ai-bot]

Comment by bchintx
Wednesday Apr 02, 2014 at 01:28 GMT

---

Changes look good to me too. Merging...