[CLOSED] Fix bug #7300 (Prefs never saved again after opening ancestor folder of user prefs.json)

[core-ai-bot]

Issue by peterflynn
Tuesday Apr 01, 2014 at 23:40 GMT
Originally opened as adobe/brackets#7376

---

Fix bug #7300 -- ensure that FileSystem always knows we've read the JSON file before we try to write to it. We don't want to enable the 'blind' flag since it will mean we virtually always overwrite external changes to the prefs file, and we don't want to start using file watchers to observe external changes on the fly since we haven't yet deeply tested having multiple watch roots active at once (see #7375).

Also:

• Rename confusing "filename" vars in PreferencesBase
• Fix JSLint errors in ProjectManager from [CLOSED] Implement multiple file exclusion sets #7026

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/7376/commits

[core-ai-bot]

Comment by peterflynn
Wednesday Apr 02, 2014 at 17:38 GMT

---

@dangoor Do you have cycles to review today, since this is in prefs code?

[core-ai-bot]

Comment by dangoor
Wednesday Apr 02, 2014 at 18:00 GMT

---

@peterflynn Sure, I will review this today.

[core-ai-bot]

Comment by dangoor
Wednesday Apr 02, 2014 at 18:33 GMT

---

Review complete. Everything looks fine to me and the change works well. I don't feel likely to be thrown off by any of the nomenclature we discussed, so I wouldn't block this PR on that. If you do want to change the name to pathname or fullPath, feel free to do so and merge without additional review.

[core-ai-bot]

Comment by peterflynn
Wednesday Apr 02, 2014 at 20:21 GMT

---

Thanks for the review! I'l just go ahead & land it now in the interest of getting on with the remaining sprint tasks...