[CLOSED] Return the css property value range in getInfoAtPos() api.

[core-ai-bot]

Issue by RaymondLim
Wednesday Apr 02, 2014 at 21:10 GMT
Originally opened as adobe/brackets#7390

---

This is required for CSS Shapes Editor to handle CSS property values spanning over multiple lines.

@JeffryBooher and@oslego Can you review this?

---

RaymondLim included the following code: https://github.com/adobe/brackets/pull/7390/commits

[core-ai-bot]

Comment by RaymondLim
Saturday Apr 05, 2014 at 00:07 GMT

---

@JeffryBooher I'm done fixing unit tests. Ready for you to land in master. I reviewed yours already. Thanks.

[core-ai-bot]

Comment by JeffryBooher
Saturday Apr 05, 2014 at 01:39 GMT

---

Done with review.@RaymondLim let me know when you're ready for me to merge

[core-ai-bot]

Comment by RaymondLim
Saturday Apr 05, 2014 at 03:37 GMT

---

@JeffryBooher Changes are pushed. Ready for re-review.

[core-ai-bot]

Comment by JeffryBooher
Saturday Apr 05, 2014 at 06:21 GMT

---

Looks good. Unit tests pass. Review Complete all comments addressed. Merging

[core-ai-bot]

Comment by JeffryBooher
Sunday Apr 06, 2014 at 22:03 GMT

---

@redmunds that's a good point about unnecessarily creating a new string but we aren't searching for the presence of whitespace, we're effectively looking for a string that is empty after removing all whitespace ...

[core-ai-bot]

Comment by redmunds
Monday Apr 07, 2014 at 03:29 GMT

---

@JeffryBooher I believe that is the same thing -- let me know if you can think of any case that this doesn't work for.

[core-ai-bot]

Comment by JeffryBooher
Monday Apr 07, 2014 at 04:48 GMT

---

@redmunds I think you could match on this: /[^\S]/ to search for any non-whitespace

[core-ai-bot]

Comment by redmunds
Monday Apr 07, 2014 at 15:22 GMT

---

@JeffryBooher \s (lowercase) is for whitespace and \S (uppercase) is for the opposite (i.e. non-whitespace).

[core-ai-bot]

Comment by JeffryBooher
Monday Apr 07, 2014 at 15:49 GMT

---

I guess on an iPhone it's hard to tell the difference :)

[core-ai-bot]

Comment by RaymondLim
Monday Apr 07, 2014 at 16:45 GMT

---

@redmunds I'll submit a pull request to clean up all the usage of trim() for this purpose. I prefer to use string.match(/\S/) instead of string.search(/\S/) since we don't really need to know the position. See this http://jsperf.com/exec-vs-match-vs-test-vs-search/5 for a comparison.

[core-ai-bot]

Comment by redmunds
Monday Apr 07, 2014 at 16:50 GMT

---

@RaymondLim According to that chart, it looks like /\S/.test(string) is even faster.

[core-ai-bot]

Comment by RaymondLim
Monday Apr 07, 2014 at 16:59 GMT

---

You're right! I was interpreting the opposite.

[core-ai-bot]

Comment by JeffryBooher
Monday Apr 07, 2014 at 18:18 GMT

---

@RaymondLim, I'm already working on a pull request