[CLOSED] File exclusions usability improvements (bug #7149)

[core-ai-bot]

Issue by peterflynn
Thursday Apr 03, 2014 at 19:51 GMT
Originally opened as adobe/brackets#7400

---

Fix several issues raised in #7149:

• When search scope is a single file, skip exclusion filter entirely (and hide it from search UI)
• If exclusions filter results in 0 files to search, show a message to that effect and leave search bar open so user can adjust filter
• When editing a filter, show how many files are still included out of the total number of files in the current search scope

Also cleans up FindInFiles a little bit to centralize the filtering code more, and simplify _doSearchInOneFile() & its call sites.

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/7400/commits

[core-ai-bot]

Comment by MarcelGerber
Thursday Apr 03, 2014 at 20:17 GMT

---

What about adding a percentage?

[core-ai-bot]

Comment by peterflynn
Thursday Apr 03, 2014 at 21:12 GMT

---

@SAPlayer I think the absolute number of files is actually more meaningful, in terms of how long the search will take to complete, etc. It's easy enough to guesstimate the percentage in your head looking at the numbers we show, anyway :-) I'd rather not have too much 'numbers overload' in the display at bottom, personally.

[core-ai-bot]

Comment by MarcelGerber
Thursday Apr 03, 2014 at 21:47 GMT

---

Ok, sounds good.

[core-ai-bot]

Comment by ingorichter
Friday Apr 04, 2014 at 19:01 GMT

---

I think we should right align the input field with the OK button and the info fields right border. What do you think?

[core-ai-bot]

Comment by ingorichter
Friday Apr 04, 2014 at 22:05 GMT

---

@peterflynn I'm done with initial review. Some minor nits, but nothing big. Works fine for me. I think we should add some more unit tests, but we can do this later if we don't have time today.

[core-ai-bot]

Comment by peterflynn
Friday Apr 04, 2014 at 23:35 GMT

---

@ingorichter Changes pushed.

For unit tests, since we have zero tests for Find in Files so far I was thinking all tests for that area would be rolled up in https://trello.com/c/lBKh0WXZ/1077-unit-tests-for-existing-find-replace-find-in-files-features

[core-ai-bot]

Comment by ingorichter
Saturday Apr 05, 2014 at 00:16 GMT

---

@peterflynn Yes, that sounds reasonable to me. Perhaps we should mention this new behavior on the card to get it covered. Otherwise it looks good to me and I'm going to merge your changes. Thanks.

[core-ai-bot]

Comment by redmunds
Saturday Apr 05, 2014 at 00:40 GMT

---

@ingorichter@peterflynn I keep forgetting about the parallel cards in the Brackets board. Maybe they should be explicitly linked?

The associated card in the Kanban Board (https://trello.com/c/qvHL6r4i/45-unit-tests-for-existing-find-replace-find-in-files-features) is already in progress and has been tasked and edited, so it's quite different from the one in Brackets board, so that's the one that needs to be updated.

Also, I copied the Task List to the pull request (adobe/brackets#7328) to make it easier to follow, so that also should be updated.

[core-ai-bot]

Comment by zaggino
Saturday Apr 05, 2014 at 00:48 GMT

---

@redmunds that trello stuff is private only? i'm getting Card not found.

[core-ai-bot]

Comment by peterflynn
Saturday Apr 05, 2014 at 00:51 GMT

---

Well, the two cards are supposed to be explicitly linked when the Kanban copy is created... but we seem like a forgetful bunch :-)

I've added tasks to the Kanban card checklist to write unit tests for the filtering stuff. @redmunds can you sync that up with your other copy of the checklist in the PR? (Or maybe it would be best to just link the PR to the card so we don't have to keep doing that...)

[core-ai-bot]

Comment by peterflynn
Saturday Apr 05, 2014 at 00:52 GMT

---

@zaggino Yeah, it had been kind of this internal team workflow thing so we didn't bother making it public while we were getting the hang of the new workflow, but due to the syncing overhead and the reduced visibility for the community, we're working now on merging it back into the main Trello board.