[CLOSED] Help menu changes, version 2

[core-ai-bot]

Issue by dangoor
Friday Apr 04, 2014 at 15:01 GMT
Originally opened as adobe/brackets#7410

---

This reverts my previous revert and changes the links.

• "Support for Brackets" goes to the [Troubleshooting](https://github.com/adobe/brackets/wiki/Troubleshooting wiki page
• "Suggest a Feature" is a new item that goes to a new wiki page

---

dangoor included the following code: https://github.com/adobe/brackets/pull/7410/commits

[core-ai-bot]

Comment by dangoor
Friday Apr 04, 2014 at 15:01 GMT

---

cc@peterflynn@bchintx

[core-ai-bot]

Comment by peterflynn
Friday Apr 04, 2014 at 16:37 GMT

---

We should think about how these changes map onto other flavors like Edge Code, too. Does the forum menu item need to stick around for that reason, for example? Or I guess the support menu item would map onto that?

[core-ai-bot]

Comment by dangoor
Friday Apr 04, 2014 at 17:47 GMT

---

Yeah, I think the support menu item would point to the forum for Edge Code.

[core-ai-bot]

Comment by dangoor
Friday Apr 04, 2014 at 17:54 GMT

---

Changes pushed.

[core-ai-bot]

Comment by JeffryBooher
Friday Apr 04, 2014 at 21:12 GMT

---

@dangoor you could do {APP_NAME} Support which is less awkward than Support for Brackets. Support for Brackets syntactically is a call for the user to help us (like a PBS Pledge Drive) whereas Brackets support is fairly standard phrasing for help using something or technical support. That would give you the flexibility to templatize the string so that the product name is determined at runtime without having to have different strings for each build.

[core-ai-bot]

Comment by peterflynn
Friday Apr 04, 2014 at 21:44 GMT

---

@JeffryBooher "Support for Using Brackets" doesn't sound like a pledge drive, and that's the string the PR currently has. But I agree "Brackets Support" sounds a little nicer nonetheless.

What do you mean about templatizing though? The string in this PR is already using {APP_NAME}...

[core-ai-bot]

Comment by JeffryBooher
Friday Apr 04, 2014 at 22:14 GMT

---

... as opposed to using two different strings for Brackets and Edge Code.
.

[core-ai-bot]

Comment by dangoor
Friday Apr 04, 2014 at 22:15 GMT

---

I'm afk for the evening... I'm fine with APP_NAME Support

On Friday, April 4, 2014, Peter Flynn notifications@github.com wrote:

@JeffryBooher https://github.com/JeffryBooher "Support for _Using_Brackets" doesn't sound like a pledge drive, and that's the string the PR
currently has. But I agree "Brackets Support" sounds a little nicer
nonetheless.

What do you mean about templatizing though? The string in this PR is
already using {APP_NAME}...

Reply to this email directly or view it on GitHubhttps://github.com/adobe/brackets/pull/7410#issuecomment-39614790
.

[core-ai-bot]

Comment by JeffryBooher
Friday Apr 04, 2014 at 22:17 GMT

---

I can make the change and merge it.

[core-ai-bot]

Comment by JeffryBooher
Saturday Apr 05, 2014 at 00:36 GMT

---

Looks good all tests pass but I ran into #7420 which seems like a recent thing but this also occurs in master and running all integration tests on the Mac is not a problem. Also running the failed tests again individually is ok.

...merging