[CLOSED] Themes in Brackets core

[core-ai-bot]

Issue by MiguelCastillo
Thursday Apr 24, 2014 at 01:08 GMT
Originally opened as adobe/brackets#7616

---

Initial commit. A few items remain to be done, but themes are now fully functional as a core component so you can start testing this out.

https://github.com/adobe/brackets/wiki/Themes

• ThemeManager goes into core.
• ExtensionLoader has special logic for themes extensions that don’t have JS
• Settings pared down to just your “General” screen
• All of the other loading/scanning code can go away
• Use jQuery promises, sorry :*(
• Settings screen should not use Knockout
• Use new prefs API
• Unit tests for theme loading and the customizations (scrollbars, etc.)

---

MiguelCastillo included the following code: https://github.com/adobe/brackets/pull/7616/commits

[core-ai-bot]

Comment by MarcelGerber
Thursday Apr 24, 2014 at 01:39 GMT

---

All used strings should be localized.

And btw, Travis failed (because of missing JSLint comments).

[core-ai-bot]

Comment by MiguelCastillo
Thursday Apr 24, 2014 at 01:48 GMT

---

Yeah, there are a few items in my list for code cleanup and integrate with what brackets already has. I think that by tomorrow or friday, code will be more inline with what we all expect :)

[core-ai-bot]

Comment by MiguelCastillo
Thursday Apr 24, 2014 at 01:49 GMT

---

Love how quickly you guys are providing feedback! Its awesome

[core-ai-bot]

Comment by dangoor
Thursday Apr 24, 2014 at 01:59 GMT

---

For some added context for those tuning in to this pull request right now: I asked Miguel if he could convert his extension into a pull request against core as something that we could begin discussing and also so that it was possible for it to load themes as extensions, which is not possible in an extension today. I added (REVIEW ONLY) because there's definitely more coming before this feature lands.

[core-ai-bot]

Comment by MiguelCastillo
Saturday Apr 26, 2014 at 13:07 GMT

---

Alright, I think we are at a point where feedback would be great. Themes code is fully integrated into Brackets.

I created a theme that is already in the Extension Registry. The theme has to have a main.js or the registry wouldn't allow me to load it. So, we might need to adjust something there. This is the git link for the theme also
https://github.com/MiguelCastillo/Brackets-VisualStudioTheme

I am going to evaluate inline editor and mixin support. adobe/brackets#4850

[core-ai-bot]

Comment by MarcelGerber
Sunday Apr 27, 2014 at 18:52 GMT

---

https://github.com/adobe/brackets/wiki/Brackets-Coding-Conventions

[core-ai-bot]

Comment by MiguelCastillo
Sunday Apr 27, 2014 at 20:39 GMT

---

So, pretty much all the feedback has been stylistic/convention. I will read the coding conventions guide; thanks@SAPlayer.

This is all fantastic, but I am really looking more for feedback regarding the code itself. I am touching stuff in ExtensionLoader.js and ExtensionManager.js. And to be honest, opinions asides, it's far more important that all that stuff functions correctly and I am not introducing regressions; I can easily remove the white spaces later and what not later.

[core-ai-bot]

Comment by MiguelCastillo
Sunday Apr 27, 2014 at 20:41 GMT

---

@TomMalbran Yeah, I have to move that stuff to the less files... I have been a bit hesitant to completely remove stuff from themes and spread it around in brackets. Emotional attachment :) I will certainly move the styles and html files over to their corresponding folders.

[core-ai-bot]

Comment by TomMalbran
Sunday Apr 27, 2014 at 20:46 GMT

---

I wanted to test this PR, but it isn't working for me. I am on the. Brackets fails while loading and doesn't even show any errors in the console, so I don't know where it fails. It loads the menus, the UI and then it crashes. Neither the project or the extensions are loaded, so somewhere before that it breaks. Not sure if the same happens to you.

One other thing. You are merging from master, but it might get easier to merge from a branch in your repo.

[core-ai-bot]

Comment by MiguelCastillo
Sunday Apr 27, 2014 at 21:02 GMT

---

@TomMalbran Yeah it has been working for me just fine... I have been doing my daily development on it.

Hmmm, I am really looking for better way to manage this merging process. I have a PR from a clone. What other way do you think would be better? Please help on this front :D

[core-ai-bot]

Comment by TomMalbran
Sunday Apr 27, 2014 at 21:10 GMT

---

I am still a bit a noob in Git, so I am not sure how you could move your changes in master to a branch. The How to Hack on Brackets wiki has some basic info on working in branches and a clone of the brackets repo: https://github.com/adobe/brackets/wiki/How-to-Hack-on-Brackets

[core-ai-bot]

Comment by MarcelGerber
Sunday Apr 27, 2014 at 21:27 GMT

---

@TomMalbran It's not important as I don't expect Miguel wants to create another PR while this one is still running. It would be better for the next PR, but nothing important.

The only thing that wouldn't be bad would be to update to the current master.@MiguelCastillo you can do that like this:

[if not already] git remote add upstream https://github.com/adobe/brackets
git fetch upstream
git merge upstream/master
git submodule update --init

It could be that there are merge conflicts (e.g. zaggino's Check for extension updates).
Well, you need to fork and clone the repo unless you are a commiter.

[core-ai-bot]

Comment by MiguelCastillo
Sunday Apr 27, 2014 at 21:28 GMT

---

@SAPlayer Running grunt does not catch these spaces between parenthesis you are talking about. Is that something we should adjust somewhere?

[core-ai-bot]

Comment by MiguelCastillo
Sunday Apr 27, 2014 at 21:28 GMT

---

@SAPlayer Thanks for those git steps dude!

[core-ai-bot]

Comment by MarcelGerber
Sunday Apr 27, 2014 at 21:30 GMT

---

I don't even know what grunt does to be honest :) You have to ask someone else.

Ah btw, before you push the changes, better test everything locally. It's easier to revert there.