[CLOSED] Change font weight of menu items to 400 instead of 200, improves readability

[core-ai-bot]

Issue by Mark-Simulacrum
Thursday Nov 06, 2014 at 13:13 GMT
Originally opened as adobe/brackets#9829

---

Fixes #9828.

Things to consider:

• May not be the only place in the UI that this error happens.
• Should the font weight used (400) be put into a LESS variable? If so, how should that variable be named?
  • We already have @font-weight-semibold: 500 and @font-weight-light: 200.

---

Mark-Simulacrum included the following code: https://github.com/adobe/brackets/pull/9829/commits

[core-ai-bot]

Comment by le717
Thursday Nov 06, 2014 at 19:46 GMT

---

FWIW. I'd call the LESS variable (if needed) @font-weight-normal. :)

[core-ai-bot]

Comment by nmabhinandan
Friday Nov 07, 2014 at 09:25 GMT

---

This definitely fixes the issue.

[core-ai-bot]

Comment by peterflynn
Friday Nov 07, 2014 at 20:28 GMT

---

Assigning to@placegraphichere for visual review. (Note: to test this on a non-Linux computer, modify Global.js so that global.brackets.nativeMenus is always set to false). Changing the font-weight seems reasonable to me, but we could also consider changing the color for a similar effect.

[core-ai-bot]

Comment by Mark-Simulacrum
Friday Nov 14, 2014 at 22:58 GMT

---

Should I squash the commits? Feels odd to me to have 3 commits for 1 tiny change.

[core-ai-bot]

Comment by ingorichter
Thursday Nov 20, 2014 at 01:57 GMT

---

@Mark-Simulacrum Do you still want to squash the commits?
@placegraphichere Did you get a chance to look at this PR?

[core-ai-bot]

Comment by Mark-Simulacrum
Thursday Nov 20, 2014 at 02:00 GMT

---

@ingorichter Squashed commits, thank you for the reminder!

[core-ai-bot]

Comment by ingorichter
Saturday Nov 22, 2014 at 00:30 GMT

---

LGTM
Before:

After:

[core-ai-bot]

Comment by ingorichter
Saturday Nov 22, 2014 at 00:30 GMT

---

@placegraphichere Do you want to have another look at the visual representation or does the change look good to you and I can merge it?

[core-ai-bot]

Comment by nmabhinandan
Saturday Nov 22, 2014 at 04:41 GMT

---

The problem was primarily in the dark theme running in Ubunut x64 OS. #9828

[core-ai-bot]

Comment by le717
Friday Jan 16, 2015 at 02:42 GMT

---

@ingorichter Do you want to get this in 1.2? While I'm not a Linux user, this does fix a visibility issue (which can effect usability), and know it if affected me I'd want this in as soon as possible.

[core-ai-bot]

Comment by nmabhinandan
Friday Jan 16, 2015 at 15:30 GMT

---

Yes please.

[core-ai-bot]

Comment by ingorichter
Thursday Jan 29, 2015 at 07:14 GMT

---

With lighter font

With heavier font