[CLOSED] Verify DOM.enable() exists before calling it

[core-ai-bot]

Issue by redmunds
Tuesday Dec 16, 2014 at 23:02 GMT
Originally opened as adobe/brackets#10195

---

This is for #10191

Targets release branch.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/10195/commits

[core-ai-bot]

Comment by JeffryBooher
Wednesday Dec 17, 2014 at 00:12 GMT

---

This change looks low-risk to me but I've since updated chrome which solved the original issue so I wouldn't be able to rollback to test it; we would need a machine with chrome 34

[core-ai-bot]

Comment by JeffryBooher
Wednesday Dec 17, 2014 at 00:34 GMT

---

LGTM...Merging

[core-ai-bot]

Comment by RaymondLim
Wednesday Dec 17, 2014 at 00:50 GMT

---

I still have Chrome 34 on my linux 32 and I still can reproduce it with this pr though.

[core-ai-bot]

Comment by RaymondLim
Wednesday Dec 17, 2014 at 00:55 GMT

---

@redmunds I got console error saying that DOM.enable wasn't found

[core-ai-bot]

Comment by redmunds
Wednesday Dec 17, 2014 at 01:00 GMT

---

@RaymondLim Can you trap the error so we can see where else DOM.enable() is being called?

[core-ai-bot]

Comment by JeffryBooher
Wednesday Dec 17, 2014 at 01:15 GMT

---

@RaymondLim the code is checking to see if it exists before calling it.

if (Inspector.DOM.enable) {
    Inspector.DOM.enable();
}

[core-ai-bot]

Comment by redmunds
Wednesday Dec 17, 2014 at 01:15 GMT

---

@Raymond Is #10191 fixed but there's still a console message? Or are you still seeing #10191?

[core-ai-bot]

Comment by RaymondLim
Wednesday Dec 17, 2014 at 04:22 GMT

---

@redmunds and@JeffryBooher We can't check the existence of DOM.enable since it is one of those we have it defined in Inspector.json file, but the browsers before Chrome 37 do not have it.