[CLOSED] Hint color names in CSS Code Hints

[core-ai-bot]

Issue by MarcelGerber
Sunday Jan 18, 2015 at 12:58 GMT
Originally opened as adobe/brackets#10410

---

Shows color names in Code Hints for CSS properties like color, background-color, border-left-color, ...

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/10410/commits

[core-ai-bot]

Comment by le717
Sunday Jan 18, 2015 at 21:44 GMT

---

Unless I'm missing something, you've completely removed currentColor. currentColor is a valid "color" with special meaning, and a standardized CSS3 spec.

[core-ai-bot]

Comment by MarcelGerber
Sunday Jan 18, 2015 at 21:50 GMT

---

Oh, I didn't know this was a valid value.
Will add it back tomorrow.

[core-ai-bot]

Comment by MarcelGerber
Monday Jan 19, 2015 at 14:17 GMT

---

@le717 Done.

[core-ai-bot]

Comment by redmunds
Wednesday Jan 21, 2015 at 00:24 GMT

---

@MarcelGerber Very cool! Merging.

@sprintr This same technique can be used to add named colors back into SVG code hints.

[core-ai-bot]

Comment by le717
Wednesday Jan 21, 2015 at 00:30 GMT

---

@MarcelGerber @redmunds Thanks for merging this! :D This has always been a curious missing feature for me, considering the built-in color editor

[core-ai-bot]

Comment by MarcelGerber
Wednesday Jan 21, 2015 at 05:27 GMT

---

Thanks for merging :)
We can possibly add a "color preview bagde" later on (a badge on the right of the hints popup), but I need to have a look at the code before.
Can a hint provider combine jQuery & rawtext hints?

[core-ai-bot]

Comment by RaymondLim
Wednesday Jan 21, 2015 at 06:20 GMT

---

@MarcelGerber Yes, you can combine raw text hints with jQuery as in the following example I used in my "user key map hints" (not in the repo yet).

code snippet in getHints that appends the assigned key to raw text command id.

            result = $.map(this._allCommands, function (value, key) {
                if (value.toLowerCase().indexOf(query.toLowerCase()) === 0) {
                    if (self.keyMap[value]) {
                        return value + "&nbsp;<span class='display-key'>" + self.keyMap[value] + "</span>";
                    } else {
                        return value;
                    }
                }
            }).sort();

code snippet in insertHint that extracts command id by excluding the appended key.

        if (hint.indexOf(" ") !== -1) {
            hint = hint.slice(0, hint.indexOf(" "));
        }