Accessing .git folder through Brackets file system adds it to the index and breaks Brackets

[marcelgerber]

1. Start a new Brackets session (don't do anything important there - it won't be saved!)
2. Do Find In Files
3. Search for anything you like, e.g. Hello
4. Click the first entry given

Result: Brackets hangs, memory consumption changes quickly, Brackets crashes in a bluescreen

It is definitely brackets-git which causes this issue, as I reproduced it with it and only it installed.

[FezVrasta]

it works for me, must be a Brackets bug, I cant find any evidence this bug is related to Brackets Git...

[marcelgerber]

Nope, I can only reproduce it with brackets-git installed/enabled.

Windows 8.1 btw

E: Here's the debug log:

[marcelgerber]

Well, I'm gonna checkout different versions/commits later in order to isolate the problem.

[marcelgerber]

It's even more strange, but e7334d8 is causing this...

[zaggino]

Is something from brackets-git executed in infinite loop? I don't have any access to Windows 8. Maybe ping someone from Brackets team who has?

cc @TomMalbran as find in files author, this bug is quite bad

[FezVrasta]

I've windows 8, no problems noticed here

[zaggino]

@SAplayer can't simulate this problem on Windows 7 so can't really fix until it's isolated.

[marcelgerber]

Investigating now.
At least I got reproducible steps (for me) now:

1. Open folder adobe/brackets (git clone, of course)
2. Find In Files: CREATE
3. Wait
4. Click any entry (but not for the current file)

Result: Brackets becomes unresponsive and blue-screens later, high load (see performance graph below, I/O peaks of 100MB/s!)

Reproduced with Brackets Shell Sprint 38, Brackets at current master, Windows 8.1, brackets-git 0.13.5 downloaded via Extension Manager, Brackets factory reset (deleted AppData/Brackets folder)

[marcelgerber]

Btw, this is the debug log outputted just before the crash:

[brackets-git] Event invoked: brackets.current.document.change - [object Object], [Document C:/Users/***/Documents/GitHub/brackets/samples/root/Getting Started/index.html (clean) (Editable) refs:2], undefined (3 listeners)
[brackets-git] cmd-spawn: C:\Program Files (x86)\Git\bin\git.exe status -u --porcelain
[brackets-git] Event invoked: brackets.file.changed - [object Object], [Directory C:/Users/***/Documents/GitHub/brackets/.git/] (1 listeners)
[brackets-git] cmd-spawn-out (1521ms;ID=10)
[brackets-git] cmd-spawn: C:\Program Files (x86)\Git\bin\git.exe status -u --porcelain
[brackets-git] cmd-spawn-out (1604ms;ID=11)
[brackets-git] cmd-spawn: C:\Program Files (x86)\Git\bin\git.exe diff --no-color -U0 -- samples/root/Getting Started/index.html
[brackets-git] Event invoked: git.status.results (2 listeners)
[brackets-git] cmd-spawn-out (248ms;ID=12)

[marcelgerber]

The failing calls are the two to git status -u --porcelain (both!) GitCli@status() and GitCli@_isFileChanged().
As soon as I enable just one of them, Brackets hangs.

Btw, in case you'd like to take a look yourself (TeamViewer or Chrome Remote Desktop), you're welcome!

[zaggino]

I'll have to look at this but probably later when I'll have more time. I still don't understand why git status (or any Git command executed) call would cause Brackets to hang in any way because they run in completely different process from Brackets.

One of the git status-es is actually a check if a file is staged or not so it should specify a filename - I'm going to fix that now (it will run much faster).