Added basic support for Git-FTP#285
Conversation
|
Probably would be better to first merge this into master and then improve this code (I know I miss some features but I was scared about developing basing my PR on an old version). |
Currently it supports: Define new scope (Git-FTP remote) Delete existing scope Switch between scopes Init scopes after defined Push to scopes Enable/Disable Git-FTP features This PR also rewrites most of the "remotes picker" feature.
|
Ok, I merged some of the stuff - you need to look at new master. I did not rewrite everything because that should be easier for you now when you see the new format. Please open a new PR and add small commits to it so I can see when you do something and comment on the code before you write a lot more. It's easier to review a commit where one function is added than a commit where half of the stuff is rewritten and added. There are code-design decisions here that need to be considered because I don't want to crowd original Git code with Git-Ftp stuff. It should be almost like a plugin into it - just like the default Brackets extensions are in the Brackets installation but are not included in main code. |
|
Thanks, I'm working to apply my patch on your code. |
|
Please do it in parts, don't try to submit too much at once. I'm almost all the time near PC and can do partial reviews and merge. Submitting about 50 lines or 1-2 big functions in one PR is ideal. |
|
Ok, I'm having big troubles trying to make it "plugin like"... the remotes picker needs just too much integration with Git-FTP to keep it separated... Will submit in few minutes the PR. |
|
No worries, I'll help you with it ;-) |
Currently it supports:
This PR also rewrites most of the "remotes picker" feature.
It's based on an old version but I'm publishing however because you've said so ^_^"