Skip to content

Princeton Rat Atlas#791

Draft
kjungwoo5 wants to merge 22 commits intobrainglobe:mainfrom
kjungwoo5:PRAtlas
Draft

Princeton Rat Atlas#791
kjungwoo5 wants to merge 22 commits intobrainglobe:mainfrom
kjungwoo5:PRAtlas

Conversation

@kjungwoo5
Copy link
Copy Markdown
Contributor

Description

Draft PR for Princeton Rat Atlas

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

What does this PR do?
Adds the Princeton Rat Atlas packaging script to BrainGlobe

References

Issue #204
Publication
Downloads

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@PolarBean
Copy link
Copy Markdown
Member

I think we should ingest this as three atlases.
There is the PRA atlas which seems to have files
PRA_WHS_v4_anns.tif & PRA.tif
but then there seem to male and female specific templates (fPRA and mPRA) and annotations. These would also be useful to ingest. I would suggest making 3 separate ingestion files but these can IMO be part of this single PR (and dont worry about this until we have the first PRA working as they will be 99% the same)

@kjungwoo5
Copy link
Copy Markdown
Contributor Author

Sounds good, I'll focus on getting the main PRA atlas ingested for now, and once it's working I'll just duplicate the script and modify it to allow for mPRA and fPRA.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
28.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@kjungwoo5 kjungwoo5 mentioned this pull request Apr 16, 2026
7 tasks
@kjungwoo5 kjungwoo5 closed this Apr 16, 2026
@kjungwoo5 kjungwoo5 reopened this Apr 16, 2026
@kjungwoo5 kjungwoo5 changed the base branch from main to PRAtlas April 16, 2026 11:07
@PolarBean PolarBean changed the base branch from PRAtlas to main April 16, 2026 12:03
@PolarBean
Copy link
Copy Markdown
Member

hey @kjungwoo5, usually these prs are to the main branch of the repo :) i changed this for you, feel free to undo it if I was incorrect

@kjungwoo5
Copy link
Copy Markdown
Contributor Author

Ah I see, thank you! I was momentarily confused as to which branch I was meant to PR it to, given that I was working off of a fork.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
75.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants