This repository was archived by the owner on Jan 17, 2025. It is now read-only.
Fix error changing ownership when deleting a user, if the current user has temporary credentials#4
Merged
winglot merged 1 commit intobrainly:masterfrom Jul 15, 2021
Conversation
…r has temporary credentials
winglot
approved these changes
Jul 15, 2021
StevenKGER
referenced
this pull request
in dbsystel/terraform-provider-redshift
Oct 25, 2024
Pin dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a user, the provider attempts to chown all of the user's objects to
$REDSHIFT_USER. If you use temporary credentials provided by GetClusterCredentials the username you need to authenticate as is prefixed with eitherIAM:orIAMA:. However, the username needed for the chown is the non-prefixed one.This PR fixes the issue by stripping these specific prefixes from the chown statements (and also parameterizes them).
You can reproduce the error like so:
Note: while this PR is in a similar vein to #3 the underlying issue isn't necessarily dependent upon the changes there.