Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Fix removing existing users from groups#81

Merged
winglot merged 1 commit intomasterfrom
fix/remove-existing-user-from-group
Sep 2, 2022
Merged

Fix removing existing users from groups#81
winglot merged 1 commit intomasterfrom
fix/remove-existing-user-from-group

Conversation

@winglot
Copy link
Copy Markdown
Member

@winglot winglot commented Sep 1, 2022

A fix to allow removing existing users from groups.

The added test case replicates an error reported by @tripolif98 in #79.

=== RUN   TestAccRedshiftGroup_RemoveExistingUser
    resource_redshift_group_test.go:145: Step 2/2 error: Error running apply: exit status 1

        Error: error reading info about user: %!s(<nil>)

          with redshift_group.group,
          on terraform_plugin_test.tf line 2, in resource "redshift_group" "group":
           2: resource "redshift_group" "group" {

--- FAIL: TestAccRedshiftGroup_RemoveExistingUser (13.19s)
FAIL
FAIL    github.com/brainly/terraform-provider-redshift/redshift 13.200s
FAIL

After fix to the switch statement is applied, the test passes.

=== RUN   TestAccRedshiftGroup_RemoveExistingUser
--- PASS: TestAccRedshiftGroup_RemoveExistingUser (16.52s)
PASS
ok      github.com/brainly/terraform-provider-redshift/redshift 16.522s

@winglot winglot added the bug Something isn't working label Sep 1, 2022
@winglot winglot merged commit fca4fde into master Sep 2, 2022
@winglot winglot deleted the fix/remove-existing-user-from-group branch September 21, 2022 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants