Open
Conversation
Andrew Kent (realark)
changed the title
Andrew Kent (realark)
force-pushed
the
ark/remote-eval-params
branch
7 times, most recently
from
9adbe3c to
9e4f26d
Compare
Andrew Kent (realark)
force-pushed
the
ark/remote-eval-params
branch
from
9e4f26d to
cbcc6bb
Compare
Andrew Kent (realark)
force-pushed
the
ark/remote-eval-params
branch
from
cbcc6bb to
641b773
Compare
Andrew Kent (realark)
force-pushed
the
ark/remote-eval-params
branch
from
641b773 to
a889769
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 7, 2026
Member
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
no blocking reviews!
| TaskResult<INPUT, OUTPUT> apply(DatasetCase<INPUT, OUTPUT> datasetCase) throws Exception; | ||
| default TaskResult<INPUT, OUTPUT> apply(DatasetCase<INPUT, OUTPUT> datasetCase) | ||
| throws Exception { | ||
| throw new UnsupportedOperationException( |
There was a problem hiding this comment.
This is technically a breaking change because both methods are default. Is that fine?
Comment on lines
+72
to
+78
| enum DataType { | ||
| STRING, | ||
| NUMBER, | ||
| BOOLEAN, | ||
| OBJECT, | ||
| ARRAY | ||
| } |
There was a problem hiding this comment.
not used anywhere
| Map<String, Object> parametersContainer = new LinkedHashMap<>(); | ||
| parametersContainer.put("type", "braintrust.staticParameters"); | ||
| parametersContainer.put("schema", schemaMap); | ||
| parametersContainer.put("source", NullNode.getInstance()); |
There was a problem hiding this comment.
why NullNode.getInstance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support
dataandmodeleval params (promptnot yet supported)