Open
Conversation
| "textEditorToolV3Param": "Tool 'str_replace_based_edit_tool' of type 'text_editor_20250728' is not supported by openai", | ||
| "webSearchToolAdvancedParam": "Tool 'web_search' of type 'web_search_20250305' is not supported by openai", | ||
| "webSearchUserLocationParam": "Tool 'web_search' of type 'web_search_20250305' is not supported by openai", | ||
| "webSearchToolAdvancedParam": "Tool 'web_search' of type 'allowed_domains' is not supported by openai", |
Contributor
Author
There was a problem hiding this comment.
allowed_domains shouldn't be translatable since there isn't an equivalent option for either Google or OpenAI.
i think this makes sense to error out instead of dropping the allowed_domains option since it feels like an important constraint defined by user that shouldn't be dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for web search between all the providers and ensures regular + streaming calls look good.