Add first-class skip_pg_for_brainstore_objects variable for no-PG mode#225
Draft
Alex Soldatchenko (soldatchenko) wants to merge 1 commit intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
skip_pg_for_brainstore_objectsas a first-class Terraform variable, replacing the need for customers to manually configure three separatebrainstore_extra_env_varsentries.When set, a single variable fans out to:
SKIP_PG_FOR_BRAINSTORE_OBJECTSon the API Handler LambdaBRAINSTORE_WAL_USE_EFFICIENT_FORMATon the API Handler Lambda (auto-enabled)BRAINSTORE_ASYNC_SCORING_OBJECTSon all Brainstore EC2 nodesBRAINSTORE_LOG_AUTOMATIONS_OBJECTSon all Brainstore EC2 nodesThis mirrors the Helm chart's
skipPgForBrainstoreObjectssingle-knob pattern.Accepted values:
""(disabled),"all","include:<type>:<uuid>,...","exclude:<type>:<uuid>,...".Open question: WAL_USE_EFFICIENT_FORMAT auto-coupling
This PR auto-enables
BRAINSTORE_WAL_USE_EFFICIENT_FORMAT = "true"wheneverskip_pg_for_brainstore_objectsis set (matching Helm chart behavior). However, it'sunclear whether this setting has the same sequencing constraint asBRAINSTORE_WAL_FOOTER_VERSION,where old Brainstore nodes can't read the new format during a rolling upgrade.If it does, auto-enabling it with no-PG could be unsafe for upgraded deployments (fresh deploys are unaffected). Waiting on confirmation before removing the draft status.
Options under consideration:
brainstore_wal_footer_versionbeing set (safer for upgrades)