Skip to content

ID-1207 Tell DRSHub its Cromwell a-knockin#7461

Merged
tlangs merged 6 commits intodevelopfrom
tl_ID-1207_tell_drshub_its_cromwell_a_knockin
Jul 30, 2024
Merged

ID-1207 Tell DRSHub its Cromwell a-knockin#7461
tlangs merged 6 commits intodevelopfrom
tl_ID-1207_tell_drshub_its_cromwell_a_knockin

Conversation

@tlangs
Copy link
Copy Markdown
Contributor

@tlangs tlangs commented Jun 27, 2024

Ticket: https://broadworkbench.atlassian.net/browse/ID-1207

We want to know where DRS Requests are coming from. So, let DRSHub know!

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@tlangs tlangs requested a review from a team as a code owner June 27, 2024 20:12
Copy link
Copy Markdown
Collaborator

@jgainerdewar jgainerdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work fine for GCP, but for Azure we'll need to update TES - it has its own DRS resolution implementation, see here: https://github.com/microsoft/ga4gh-tes/blob/main/src/Tes.Runner/Storage/DrsUriTransformationStrategy.cs

@tlangs tlangs merged commit f9b91f7 into develop Jul 30, 2024
@tlangs tlangs deleted the tl_ID-1207_tell_drshub_its_cromwell_a_knockin branch July 30, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants