[WX-1782] Cloud Billing Dependency + Updates#7490
Merged
Conversation
THWiseman
commented
Aug 9, 2024
| "com.google.protobuf" % "protobuf-java" % "3.25.3", | ||
| ) | ||
|
|
||
| val servicesDependencies: List[ModuleID] = List( |
Contributor
Author
There was a problem hiding this comment.
This was moved lower in the file to be below the googleCloudDependencies definition.
Two changes:
- added
"com.google.cloud" % "google-cloud-billing" % "2.47.0"to the top - added
++ googleCloudDependenciesto the end
THWiseman
changed the title
jgainerdewar
approved these changes
Aug 9, 2024
Collaborator
jgainerdewar
left a comment
jgainerdewar
left a comment
There was a problem hiding this comment.
If CI likes it I like it.
aednichols
approved these changes
Aug 9, 2024
Collaborator
aednichols
left a comment
aednichols
left a comment
There was a problem hiding this comment.
LGTM 👍
One optional suggestion that may make life easier in the future.
| exclude("org.springframework", "spring-jcl"), | ||
| "org.apache.httpcomponents.client5" % "httpclient5" % apacheHttpClient5V // Needed for rest-template connection pooling | ||
|
|
||
| ) ++ testDatabaseDependencies ++ akkaHttpDependencies ++ mockServerDependencies ++ googleCloudDependencies |
Collaborator
There was a problem hiding this comment.
Is it feasible to break up googleCloudDependencies and bring only that smaller chunk into services?
Right now its value is <a bunch of individual stuff> ++ googleGenomicsV2Alpha1Dependency ++ googleLifeSciencesV2BetaDependency ++ googleBatchv1Dependency and I'm pretty sure services doesn't need any of the job running stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated a few dependencies that we need in order to use the Cloud Billing SDK.
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes