False positive on Edge 17 when Chrome >= 51 is present

[DimitarNestorov]

Our website doesn't work on Edge 17 but the regex would say otherwise.
Here's a minimal browserslist config that should return false on Edge 17, but is true:

[
    "chrome >= 51",
    "edge >= 18"
]

Omitting the Chrome line returns false.

[DimitarNestorov]

Not sure if you have access to Edge 17, here's it's userAgent:

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

[dangreen]

@DimitarNestorov

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134

Chrome/64.0.3282.140 is chrome >= 51

[dangreen]

Edge user agent is strange...

[DimitarNestorov]

That's right Edge reports Chrome 64 so that libraries like yours wouldn't discard it as an unsupported browser. The actual engine that the browser uses isn't Chromium yet but is EdgeHTML. I still remember how browser detection websites reported Edge as Chrome when it just came out. And also it had bugs that only IE 11 had.

[dangreen]

@DimitarNestorov ok, I need some time to think about some workaround for Edge ua.

[dangreen]

@DimitarNestorov

Please try demo and report about results. After your confirmation I will publish new release.

Explanation:

If browserslist query contains Chrome < 74 and Edge <= 18, patch will be applied to Chrome regexp.

1. Last ever (?) EdgeHTML version is 18 (https://en.wikipedia.org/wiki/Microsoft_Edge)
2. First known Chromium Edge has Chrome 74 version (https://blogs.windows.com/msedgedev/2019/04/08/microsoft-edge-preview-channel-details/#HzAbspiQ4poHQRVc.97)

[DimitarNestorov]

Edge 17:

Edge 18:

Edge Chromium 75 (notice how it says Edg instead of Edge):

[dangreen]

Edge Chromium 75 (notice how it says Edg instead of Edge):

Anyway, all Chrome-based browsers should be detected as Chrome.

[dangreen]

v1.2.0-beta