Add a reusable StringPool for interning strings#12536
Merged
Merged
Conversation
alexcrichton
approved these changes
Feb 5, 2026
| } | ||
|
|
||
| impl TryClone for Atom { | ||
| fn try_clone(&self) -> core::result::Result<Self, OutOfMemory> { |
Member
There was a problem hiding this comment.
This can be just Result instead of core::result::Result I think?
|
|
||
| /// Strings in this pool. These must never be mutated or reallocated once | ||
| /// inserted. | ||
| strings: Vec<String>, |
Member
There was a problem hiding this comment.
Perhaps Box<str> instead of String to further emphasize the lack of reallocation + mutation?
Comment on lines
+24
to
+26
| /// A map from each string in this pool (as an unsafe borrow from | ||
| /// `self.strings`) to its `Atom`. | ||
| map: HashMap<&'static str, Atom>, |
Member
There was a problem hiding this comment.
Given the self-borrowing nature here, this I think would be a good use case for ManuallyDrop and the destructor documents-via-code that strings is destroyed after map
github-actions
Bot
added
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
And make sure it handles allocation failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make sure it handles allocation failure.
Depends on #12534 and #12535