Add more CLI flags for wasm features#917
Merged
alexcrichton merged 4 commits intobytecodealliance:masterfrom Feb 7, 2020
Merged
Add more CLI flags for wasm features#917alexcrichton merged 4 commits intobytecodealliance:masterfrom
alexcrichton merged 4 commits intobytecodealliance:masterfrom
Conversation
This commit adds a few more flags to enable wasm features via the CLI, mirroring the existing `--enable-simd` flag: * `--enable-reference-types` * `--enable-multi-value` * `--enable-threads` * `--enable-bulk-memory` Additionally the bulk memory feature is now automatically enabled if `reference-types` or `threads` are enabled since those two proposals largely depend on `bulk-memory`.
Member
|
Should we have an |
Member
Author
|
Sounds good to me! Added now |
Member
+1 from me |
peterhuene
approved these changes
Feb 7, 2020
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
👍 Just some comment suggestions. The doc comments for the new options are user-facing, so those got special attention for consistency. Please feel free to resolve the review comments if you don't like the suggestions.
Co-Authored-By: Peter Huene <peterhuene@protonmail.com>
Co-Authored-By: Peter Huene <peterhuene@protonmail.com>
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 19, 2024
Some of this originated in bytecodealliance#917 but nowadays it shouldn't be necessary to control proposals like this. Instead it's probably best nowadays to throw configuration at `wasmparser` and use its definition of features to determine whether constructs make sense or not. This reduces the amount of bits and pieces Wasmtime has to do and avoids interactions such as bytecodealliance#9622. Closes bytecodealliance#9622
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 19, 2024
Some of this originated in bytecodealliance#917 but nowadays it shouldn't be necessary to control proposals like this. Instead it's probably best nowadays to throw configuration at `wasmparser` and use its definition of features to determine whether constructs make sense or not. This reduces the amount of bits and pieces Wasmtime has to do and avoids interactions such as bytecodealliance#9622. Closes bytecodealliance#9622
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Some of this originated in #917 but nowadays it shouldn't be necessary to control proposals like this. Instead it's probably best nowadays to throw configuration at `wasmparser` and use its definition of features to determine whether constructs make sense or not. This reduces the amount of bits and pieces Wasmtime has to do and avoids interactions such as #9622. Closes #9622
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a few more flags to enable wasm features via the CLI,
mirroring the existing
--enable-simdflag:--enable-reference-types--enable-multi-value--enable-threads--enable-bulk-memoryAdditionally the bulk memory feature is now automatically enabled if
reference-typesorthreadsare enabled since those two proposalslargely depend on
bulk-memory.