Skip to content

Add GITHUB_TOKEN default value in action.yml#341

Merged
benschwarz merged 1 commit into
calibreapp:mainfrom
kdeldycke:patch-2
Aug 26, 2025
Merged

Add GITHUB_TOKEN default value in action.yml#341
benschwarz merged 1 commit into
calibreapp:mainfrom
kdeldycke:patch-2

Conversation

@kdeldycke

Copy link
Copy Markdown
Contributor

What does this PR introduce?

Add default value for the GITHUB_TOKEN field.

Related issues

That's just a quality of life improvement, so we don't need to specify it by default.

Added GITHUB_TOKEN input for pull request operations.
@kdeldycke kdeldycke requested a review from benschwarz as a code owner August 26, 2025 09:47
@CLAassistant

CLAassistant commented Aug 26, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@kdeldycke kdeldycke changed the title Add GITHUB_TOKEN input to action.yml Add GITHUB_TOKEN default value in action.yml Aug 26, 2025
@benschwarz

Copy link
Copy Markdown
Member

Nice @kdeldycke 🙇‍♂️

Once you've signed the CLA and tests pass, I'll get it straight onto #main

@benschwarz benschwarz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I didn't realise we could set the default like this.

@kdeldycke

kdeldycke commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

CLA signed! :)

@benschwarz benschwarz merged commit 2dcd418 into calibreapp:main Aug 26, 2025
3 checks passed
@kdeldycke

Copy link
Copy Markdown
Contributor Author

Nice. I didn't realise we could set the default like this.

Not my first time: AndreasAugustin/actions-template-sync#483 ! 😉

@kdeldycke

Copy link
Copy Markdown
Contributor Author

And thanks for the merge! :)

@kdeldycke kdeldycke deleted the patch-2 branch August 26, 2025 09:56
@karlhorky

karlhorky commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Nice! Does this default value mean that the with.GITHUB_TOKEN config can be entirely removed from the readme / examples?

@kdeldycke

Copy link
Copy Markdown
Contributor Author

Nice! Does this default value mean that the with.GITHUB_TOKEN config can be entirely removed?

Yes! That's the point! :)

@karlhorky

karlhorky commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

@kdeldycke great, so another PR should be opened to update the readme too?

Right now, there are a lot of with.GITHUB_TOKEN usages in the readme and examples.

@karlhorky

karlhorky commented Aug 30, 2025

Copy link
Copy Markdown
Contributor

@kdeldycke @benschwarz should I open a PR to remove all readme docs for with.GITHUB_TOKEN?

karlhorky added a commit to karlhorky/image-actions that referenced this pull request Aug 30, 2025
After calibreapp#341 the `GITHUB_TOKEN` input parameter isn't needed unless customizing the token
@karlhorky

Copy link
Copy Markdown
Contributor

I opened one here:

kdeldycke added a commit to kdeldycke/repomatic that referenced this pull request Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants