Fixed flaky tests in test_context.py#555
Open
yashsaboo wants to merge 2 commits intocanonical-ols:masterfrom
Open
Fixed flaky tests in test_context.py#555yashsaboo wants to merge 2 commits intocanonical-ols:masterfrom
yashsaboo wants to merge 2 commits intocanonical-ols:masterfrom
Conversation
Fixed test_context.py flaky tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
test_context_apiandtest_null_contextare flaky in nature.TestCase passes consistently in the actual order with command:
TestCase fails when one randomises the order in
test_context.pymodule by using the plugin pytest-random-order with command:The victims,
test_context_apiandtest_null_context, fails in a failing test order because there is at least one test that runs before the victim and “pollutes” the state (e.g., global state: here, it isContext()) on which the victim depends. (Paper)After investigation, we found the polluter test to be
test_context_geventandtest_context_eventletFor
test_context_gevent: --random-order-seed=795276For
test_context_eventlet: --random-order-seed=570036Potential Fix: After the polluters are run, reset the Context() to its initial state so that it does not pollute the victims.
Please let us know if you require the pass and fail logs.
Contributors:
Yash Saboo
Nirupam K N