Skip to content

support celery<4.4.3#557

Open
verterok wants to merge 2 commits intocanonical-ols:masterfrom
verterok:support-celery-4.4.2
Open

support celery<4.4.3#557
verterok wants to merge 2 commits intocanonical-ols:masterfrom
verterok:support-celery-4.4.2

Conversation

@verterok
Copy link
Copy Markdown
Contributor

@verterok verterok commented Dec 8, 2020

allow/support celery<4.4.3

@verterok verterok changed the title support celery<=4.4.3 support celery<=4.4.3 (fixes #556) Dec 8, 2020
@verterok verterok changed the title support celery<=4.4.3 (fixes #556) support celery<=4.4.3 Dec 8, 2020
@verterok
Copy link
Copy Markdown
Contributor Author

verterok commented Dec 8, 2020

fixes #556

Copy link
Copy Markdown
Contributor

@maxiberta maxiberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! <4.4.3 seems to contradict the PR title. Still, why not just <5.0 so that it's compatible with eg. celery 4.4.7?

@verterok verterok changed the title support celery<=4.4.3 support celery<4.4.3 Dec 8, 2020
@verterok
Copy link
Copy Markdown
Contributor Author

verterok commented Dec 8, 2020

Thanks! <4.4.3 seems to contradict the PR title. Still, why not just <5.0 so that it's compatible with eg. celery 4.4.7?

fixed the title, I tested IRL with 4.4.2 :)
can't assure things work with a different version

Copy link
Copy Markdown
Contributor

@Roadmaster Roadmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM the title and code are now consistent and it seems OK not to go overboard with supported versions if only 4.4.2 and lower was tested.

Copy link
Copy Markdown
Contributor

@maxiberta maxiberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough +1

@bloodearnest
Copy link
Copy Markdown
Contributor

Yo.

You may want to bump the minimum supported kombu/celery versions, there was some incompatibility with older versions that prevented supporting newer versions of kombu IIRC. We had to maintain support for the older version because SCA used it I think.

@verterok
Copy link
Copy Markdown
Contributor Author

Hola!

You may want to bump the minimum supported kombu/celery versions, there was some incompatibility with older versions that prevented supporting newer versions of kombu IIRC. We had to maintain support for the older version because SCA used it I think.

Thanks for the details, will check SCA versions and update the PR, but still need to figure out what to do with travis and the failing builds (SIGSEGV: https://travis-ci.org/github/canonical-ols/talisker/builds/748545879)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants