support celery<4.4.3#557
Conversation
|
fixes #556 |
maxiberta
left a comment
There was a problem hiding this comment.
Thanks! <4.4.3 seems to contradict the PR title. Still, why not just <5.0 so that it's compatible with eg. celery 4.4.7?
fixed the title, I tested IRL with 4.4.2 :) |
|
Yo. You may want to bump the minimum supported kombu/celery versions, there was some incompatibility with older versions that prevented supporting newer versions of kombu IIRC. We had to maintain support for the older version because SCA used it I think. |
|
Hola!
Thanks for the details, will check SCA versions and update the PR, but still need to figure out what to do with travis and the failing builds (SIGSEGV: https://travis-ci.org/github/canonical-ols/talisker/builds/748545879) Cheers! |
allow/support celery<4.4.3