chore: Address TiCS coding standards warnings for public JS (#5106)

Author: steverydz

static/js/base/ga.ts

@@ -58,7 +58,7 @@ if (typeof window.dataLayer !== "undefined") {
       return;
     }
 
-    target = eventTarget.closest("a")!;
+    target = eventTarget.closest("a") as HTMLAnchorElement;
 
     if (!target) {
       target = eventTarget.closest("button")!;

static/js/public/scroll-to.ts

@@ -1,5 +1,8 @@
-export function animateScrollTo(to: string | number | HTMLElement, offset = 0) {
-  const element = (document.scrollingElement as HTMLElement) || window;
+export function animateScrollTo(
+  to: HTMLElement | number | string,
+  offset = 0,
+): void {
+  const element = document.scrollingElement!;
 
   if (typeof to === "string") {
     to = document.querySelector(to) as HTMLElement;
@@ -12,14 +15,13 @@ export function animateScrollTo(to: string | number | HTMLElement, offset = 0) {
   }
   to = to - offset;
 
-  if (element.scrollTo) {
-    element.scrollTo({ top: to, left: 0, behavior: "smooth" });
-  } else {
-    element.scrollTop = to;
-  }
+  element.scrollTo({ top: to, left: 0, behavior: "smooth" });
 }
 
-export function initLinkScroll(link: HTMLLinkElement, { offset = 0 }) {
+export function initLinkScroll(
+  link: HTMLLinkElement,
+  { offset = 0 }: { offset: number },
+): void {
   if (link && (link.dataset.scrollTo || link.href)) {
     const href =
       (link.dataset.scrollTo as string) ||
@@ -29,7 +31,9 @@ export function initLinkScroll(link: HTMLLinkElement, { offset = 0 }) {
       link.addEventListener("click", (event) => {
         event.preventDefault();
         animateScrollTo(target, offset);
-        setTimeout(() => window.history.pushState({}, "", href), 100);
+        setTimeout(() => {
+          window.history.pushState({}, "", href);
+        }, 100);
       });
     }
   }

static/js/public/snap-details/embeddedCard.ts

@@ -1,15 +1,19 @@
 import { initEmbeddedCardPicker } from "./publicise";
 
-const showEl = (el: { classList: { remove: (arg0: string) => void } }) =>
+const showEl = (el: {
+  classList: { remove: (arg0: string) => void };
+}): void => {
   el.classList.remove("u-hide");
-const hideEl = (el: { classList: { add: (arg0: string) => void } }) =>
+};
+const hideEl = (el: { classList: { add: (arg0: string) => void } }): void => {
   el.classList.add("u-hide");
+};
 
 function toggleModal(
   modal: HTMLElement,
-  show?: boolean | undefined,
-  initCallback?: { (): void; (): void } | undefined,
-) {
+  show?: boolean,
+  initCallback?: { (): void; (): void },
+): void {
   if (typeof show === "undefined") {
     show = modal.classList.contains("u-hide");
   }
@@ -39,7 +43,7 @@ export default function initEmbeddedCardModal(snapName: string): void {
   const buttonRadios = modal.querySelectorAll("input[name=store-button]");
   const optionButtons = modal.querySelectorAll("input[type=checkbox]");
 
-  function updateHeightCallback() {
+  function updateHeightCallback(): void {
     // adjust the height of the modal to size of the frame
     dialog.style.minHeight = "";
 
@@ -48,10 +52,6 @@ export default function initEmbeddedCardModal(snapName: string): void {
     }, 1);
   }
 
-  function initFrame() {
-    renderCard();
-  }
-
   const renderCard = initEmbeddedCardPicker({
     snapName,
     previewFrame,
@@ -61,6 +61,10 @@ export default function initEmbeddedCardModal(snapName: string): void {
     updateHeightCallback,
   });
 
+  function initFrame(): void {
+    renderCard();
+  }
+
   toggle.addEventListener("click", (event) => {
     event.preventDefault();
     toggleModal(modal, true, initFrame);