chore: Address TiCS coding standards warnings for public JS

[steverydz]

Done

Addressed TiCS coding standards warnings for public JS

• Added return types to functions
• Minor linting issues
• Removing unnecessary if statements

How to QA

• All required checks should pass
• Go to https://snapcraft-io-5106.demos.haus/install/code/arch
• Click "Install"
• Page should scroll down
• Go to https://snapcraft-io-5106.demos.haus/code
• Click "Create embeddable card"
• A modal should open

[webteam-app]

Demo

Jenkins

demos.haus

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.16%. Comparing base (b8b6b55) to head (ab68fe2).
Report is 308 commits behind head on main.

Files with missing lines	Patch %	Lines
static/js/base/ga.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5106       +/-   ##
===========================================
- Coverage   66.80%   53.16%   -13.64%     
===========================================
  Files         113      194       +81     
  Lines        3714     4460      +746     
  Branches      965      659      -306     
===========================================
- Hits         2481     2371      -110     
- Misses       1098     1915      +817     
- Partials      135      174       +39     

Files with missing lines	Coverage Δ
static/js/base/ga.ts	22.58% <0.00%> (ø)

... and 213 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abbiesims]

LGTM 👍