Update JSON response format for consistency with other endpoints

Author: bartaz

tests/publisher/cve/test_has_cve_api.py

@@ -46,6 +46,7 @@ def test_has_cves_for_canonical_user(self, mock_get_snap_info, mock_get):
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(data["success"], True)
+        self.assertEqual(data["data"]["revisions"], [123, 321])
 
     @patch(
         "webapp.publisher.cve.cve_helper.CveHelper.get_revisions_with_cves",

webapp/publisher/cve/cve_views.py

@@ -48,21 +48,21 @@ def get_revisions_with_cves(snap_name):
     )
     if not has_access:
         return (
-            flask.jsonify({"success": False, "error": error_message}),
+            flask.jsonify({"success": False, "message": error_message}),
             status_code,
         )
 
     revisions_with_cves = CveHelper.get_revisions_with_cves(snap_name)
     if len(revisions_with_cves) > 0:
         return flask.jsonify(
-            {"success": True, "revisions": revisions_with_cves}
+            {"success": True, "data": {"revisions": revisions_with_cves}}
         )
     else:
         return (
             flask.jsonify(
                 {
                     "success": False,
-                    "error": f"CVEs data for '{snap_name}' snap not found.",
+                    "message": f"CVEs data for '{snap_name}' snap not found.",
                 }
             ),
             404,