Skip to content

chore: Prepare types for React 19 upgrade#5077

Merged
steverydz merged 1 commit intomainfrom
prepare-for-react-19-upgrade
Apr 3, 2025
Merged

chore: Prepare types for React 19 upgrade#5077
steverydz merged 1 commit intomainfrom
prepare-for-react-19-upgrade

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Apr 3, 2025

Done

Update types to prepare for the upgrade to React 19

How to QA

  • All checks should pass

Testing

  • This PR has tests
  • No testing required (explain why): No behavioural changes

@webteam-app
Copy link
Copy Markdown

@bartaz
Copy link
Copy Markdown
Member

bartaz commented Apr 3, 2025

There still seems to be ReactNode used in useActiveDeviceMetrics.test.tsx - not sure if it was intended omission?

Copy link
Copy Markdown
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steverydz
Copy link
Copy Markdown
Contributor Author

There still seems to be ReactNode used in useActiveDeviceMetrics.test.tsx - not sure if it was intended omission?

Yes, ReactNode is needed in that particular file due to the way the createWrapper function works. It shouldn't cause any problems with React 19 as far as I can tell.

@steverydz steverydz merged commit b6b87c9 into main Apr 3, 2025
11 checks passed
@steverydz steverydz deleted the prepare-for-react-19-upgrade branch April 3, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants