fix: Fix welcome heading when publisher has no snaps#5079
Merged
Conversation
Demo
Jenkins 
demos.haus 
bartaz
changed the title
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
static/js/publisher/components/PublishedSnapList/PublishedSnapList.tsx:82
- Consider adding visual regression tests to verify the conditional rendering behavior of the EmptySnapList component when there are no snaps.
{isEmpty && <EmptySnapList />}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Currently if published has no snaps we show both "My published snaps" and "Get started" headings (floated next to one another).
This PR fixes this by hiding "My published snaps" heading if there are no snaps.
How to QA
Testing