Skip to content

fix: Fix compiler warnings from the TiCS dashboard#5091

Merged
steverydz merged 1 commit intomainfrom
TiCS-compiler-warnings
Apr 9, 2025
Merged

fix: Fix compiler warnings from the TiCS dashboard#5091
steverydz merged 1 commit intomainfrom
TiCS-compiler-warnings

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Apr 9, 2025

Done

Addresses compiler warnings from the TiCS dashboard

  • Update incorrect types
  • Remove unused SettingsData type
  • Renamed constants.js to constants.ts - no type changes necessary
  • Prefixed unused positional arguments with _ to show they are intentionally unused

How to QA

All checks should pass

@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit 153f0a1 into main Apr 9, 2025
11 checks passed
@steverydz steverydz deleted the TiCS-compiler-warnings branch April 9, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants