Skip to content

chore: Address TiCS coding standards warnings in libs JS#5107

Merged
steverydz merged 1 commit intomainfrom
TiCS-coding-standards-libs-js
Apr 22, 2025
Merged

chore: Address TiCS coding standards warnings in libs JS#5107
steverydz merged 1 commit intomainfrom
TiCS-coding-standards-libs-js

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Apr 22, 2025

Done

Address TiCS coding standards warnings in libs JS

  • Ordered type unions
  • Use records for object types
  • Add types to functions

How to QA

All checks should pass

@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steverydz steverydz merged commit 13885f9 into main Apr 22, 2025
11 checks passed
@steverydz steverydz deleted the TiCS-coding-standards-libs-js branch April 22, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants