chore: Address TiCS code coverage warnings for publisher utils#5109
chore: Address TiCS code coverage warnings for publisher utils#5109
Conversation
Demo
Jenkins 
demos.haus ![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| }); | ||
|
|
||
| test("sets public_metrics_blacklist if only territories", () => { |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| }), | ||
| ); | ||
|
|
||
| expect(changes.public_metrics_blacklist).toBeDefined(); |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
|
|
||
| expect(changes.public_metrics_blacklist).toBeDefined(); | ||
|
|
||
| if (changes.public_metrics_blacklist) { |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| expect(changes.public_metrics_blacklist).toBeDefined(); | ||
|
|
||
| if (changes.public_metrics_blacklist) { | ||
| expect(changes.public_metrics_blacklist).toHaveLength(1); |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
|
|
||
| if (changes.public_metrics_blacklist) { | ||
| expect(changes.public_metrics_blacklist).toHaveLength(1); | ||
| expect(changes.public_metrics_blacklist[0]).toEqual( |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| }), | ||
| ); | ||
|
|
||
| expect(changes.public_metrics_blacklist).toBeDefined(); |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
|
|
||
| expect(changes.public_metrics_blacklist).toBeDefined(); | ||
|
|
||
| if (changes.public_metrics_blacklist) { |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| expect(changes.public_metrics_blacklist).toBeDefined(); | ||
|
|
||
| if (changes.public_metrics_blacklist) { | ||
| expect(changes.public_metrics_blacklist).toHaveLength(2); |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
|
|
||
| if (changes.public_metrics_blacklist) { | ||
| expect(changes.public_metrics_blacklist).toHaveLength(2); | ||
| expect(changes.public_metrics_blacklist[0]).toEqual( |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
| expect(changes.public_metrics_blacklist[0]).toEqual( | ||
| "installed_base_by_country_percent", | ||
| ); | ||
| expect(changes.public_metrics_blacklist[1]).toEqual( |
There was a problem hiding this comment.
[Inclusive naming check] reported by reviewdog 🐶
[warning] blacklist may be insensitive, use denylist, blocklist instead
codeEmpress1
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
3 participants
Done
Adds tests for the
getListingChangesutilityHow to QA
The
test-jscheck should passTesting