Skip to content

chore: Remove unnecessary JS file#5112

Merged
steverydz merged 1 commit intomainfrom
WD-21631-remove-scroll-to-file
Apr 25, 2025
Merged

chore: Remove unnecessary JS file#5112
steverydz merged 1 commit intomainfrom
WD-21631-remove-scroll-to-file

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Apr 25, 2025

Done

Removes the scroll-to file as it can be achieved with CSS and therefore is less error-prone. The JS also isn't really testable so this will improve our code coverage score on the TiCS dashboard, albeit marginly.

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): Removing code

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-21631
Fixes https://warthogs.atlassian.net/browse/WD-21686

@webteam-app
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.58%. Comparing base (b8b6b55) to head (907ce74).
Report is 314 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5112       +/-   ##
===========================================
- Coverage   66.80%   53.58%   -13.22%     
===========================================
  Files         113      198       +85     
  Lines        3714     4604      +890     
  Branches      965      676      -289     
===========================================
- Hits         2481     2467       -14     
- Misses       1098     1959      +861     
- Partials      135      178       +43     

see 218 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit 48df839 into main Apr 25, 2025
15 checks passed
@steverydz steverydz deleted the WD-21631-remove-scroll-to-file branch April 25, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants