Skip to content

WD-21811 - snap icon causes Internal Server Error#5118

Merged
alvaromateo merged 6 commits intomainfrom
WD-21811-snap-icon-causes-Internal-Server-Error
May 12, 2025
Merged

WD-21811 - snap icon causes Internal Server Error#5118
alvaromateo merged 6 commits intomainfrom
WD-21811-snap-icon-causes-Internal-Server-Error

Conversation

@alvaromateo
Copy link
Copy Markdown
Contributor

@alvaromateo alvaromateo commented Apr 29, 2025

Done

  • Fixes data not being refreshed in the hidden PreviewForm present in ListingForm.tsx
  • Fixes Internal Server Error caused when previewing a snap page when a new icon has been added and there's a blob image only present in the browser.

How to QA

  • Check out this PR
  • Execute dotrun and access the server at http://127.0.0.1:8004/
  • Visit any snap listing page, i.e. http://127.0.0.1:8004/tdhcad/listing
  • Add an icon image from your computer
  • Click on the Preview button

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes WD-21811

@webteam-app
Copy link
Copy Markdown

@alvaromateo
Copy link
Copy Markdown
Contributor Author

I didn't see any test at all for the Preview page. I don't know if it is not testable or missing for any other reason.
Should I work on adding some unit tests for it?

@steverydz
Copy link
Copy Markdown
Contributor

I didn't see any test at all for the Preview page. I don't know if it is not testable or missing for any other reason. Should I work on adding some unit tests for it?

@alvaromateo To my knowledge there isn't a specific reason why that page isn't tested. Our test coverage isn't as good as it could be so any tests to cover new or existing work are always welcome.

Copy link
Copy Markdown
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alvaromateo alvaromateo force-pushed the WD-21811-snap-icon-causes-Internal-Server-Error branch from 590b63a to def4d5b Compare May 8, 2025 21:52
@alvaromateo alvaromateo force-pushed the WD-21811-snap-icon-causes-Internal-Server-Error branch from 05b3d23 to c5469ca Compare May 8, 2025 22:28
Copy link
Copy Markdown
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alvaromateo alvaromateo merged commit e9d4772 into main May 12, 2025
12 checks passed
@alvaromateo alvaromateo deleted the WD-21811-snap-icon-causes-Internal-Server-Error branch May 12, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants