Skip to content

fix: ensure progressive releases show in release ui#5119

Merged
Lukewh merged 1 commit intomainfrom
lukewh/progressive-releases-spike
Apr 30, 2025
Merged

fix: ensure progressive releases show in release ui#5119
Lukewh merged 1 commit intomainfrom
lukewh/progressive-releases-spike

Conversation

@Lukewh
Copy link
Copy Markdown
Contributor

@Lukewh Lukewh commented Apr 30, 2025

Done

  • Updated logic around showing progressive releases
  • prettier went ham, sorry

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): Legacy, none of this has tests :(

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the progressive release display logic in the release UI while cleaning up code formatting and export order.

  • Updated the conditional logic for adding progressive channels.
  • Simplified progressive release checks in the revisions list row.
  • Reordered exports and adjusted formatting for consistency.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
static/js/publisher/pages/Releases/releasesState.js Changed progressive check from AND to OR to include releases with either percentage value defined.
static/js/publisher/pages/Releases/components/revisionsListRow.js Added an extra condition for progressive releases and used a ternary that can be simplified.
static/js/publisher/pages/Releases/components/revisionsList.js Reordered exports and added trailing commas for improved readability.
static/js/publisher/pages/Releases/Releases.tsx Reordered imported components for consistency.
static/js/publisher/pages/Metrics/metrics/graphs/activeDevicesGraph/tooltips.ts Adjusted the tooltip position logic with minor formatting changes.
Comments suppressed due to low confidence (1)

static/js/publisher/pages/Releases/components/revisionsListRow.js:45

  • [nitpick] The ternary operator is redundant here; returning the boolean expression directly would simplify the code.
revision.prog_channels.includes(`${track}/${risk}`) && revision.progressive ? true : false;

Comment thread static/js/publisher/pages/Releases/releasesState.js
Copy link
Copy Markdown
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lukewh Lukewh merged commit 7295c10 into main Apr 30, 2025
12 checks passed
@Lukewh Lukewh deleted the lukewh/progressive-releases-spike branch April 30, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants