fix: ensure progressive releases show in release ui#5119
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the progressive release display logic in the release UI while cleaning up code formatting and export order.
- Updated the conditional logic for adding progressive channels.
- Simplified progressive release checks in the revisions list row.
- Reordered exports and adjusted formatting for consistency.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| static/js/publisher/pages/Releases/releasesState.js | Changed progressive check from AND to OR to include releases with either percentage value defined. |
| static/js/publisher/pages/Releases/components/revisionsListRow.js | Added an extra condition for progressive releases and used a ternary that can be simplified. |
| static/js/publisher/pages/Releases/components/revisionsList.js | Reordered exports and added trailing commas for improved readability. |
| static/js/publisher/pages/Releases/Releases.tsx | Reordered imported components for consistency. |
| static/js/publisher/pages/Metrics/metrics/graphs/activeDevicesGraph/tooltips.ts | Adjusted the tooltip position logic with minor formatting changes. |
Comments suppressed due to low confidence (1)
static/js/publisher/pages/Releases/components/revisionsListRow.js:45
- [nitpick] The ternary operator is redundant here; returning the boolean expression directly would simplify the code.
revision.prog_channels.includes(`${track}/${risk}`) && revision.progressive ? true : false;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
How to QA
snapcraft status snapdTesting
Issue / Card
Fixes #
Screenshots