Skip to content

chore: Add tests for publisher metrics#5120

Merged
steverydz merged 2 commits intomainfrom
WD-21700-add-publisher-metrics-tests
May 1, 2025
Merged

chore: Add tests for publisher metrics#5120
steverydz merged 2 commits intomainfrom
WD-21700-add-publisher-metrics-tests

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Apr 30, 2025

Done

Adds tests for the publisher metrics component

  • Added labels to the filters for accessibility purposes and also to make it easier to test
  • Moved mocked metrics data from other tests into test utils

How to QA

The test-js check should pass

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-21700

@webteam-app
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.07%. Comparing base (b8b6b55) to head (7826368).
Report is 319 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5120      +/-   ##
==========================================
- Coverage   66.80%   57.07%   -9.73%     
==========================================
  Files         113      205      +92     
  Lines        3714     4885    +1171     
  Branches      965      704     -261     
==========================================
+ Hits         2481     2788     +307     
- Misses       1098     1893     +795     
- Partials      135      204      +69     
Files with missing lines Coverage Δ
...blisher/pages/Metrics/ActiveDeviceMetricFilter.tsx 50.00% <ø> (ø)
...js/publisher/test-utils/mockActiveDeviceMetrics.ts 100.00% <100.00%> (ø)
...ic/js/publisher/test-utils/mockTerritoryMetrics.ts 100.00% <100.00%> (ø)

... and 222 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@steverydz steverydz merged commit 5e9fd15 into main May 1, 2025
15 checks passed
@steverydz steverydz deleted the WD-21700-add-publisher-metrics-tests branch May 1, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants