feat(ui): Add download size display to channel table (#1864)#5353
feat(ui): Add download size display to channel table (#1864)#5353gajeshbhat wants to merge 3 commits intocanonical:mainfrom
Conversation
|
gajeshbhat is not a collaborator of the repo |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5353 +/- ##
===========================================
- Coverage 66.80% 42.39% -24.41%
===========================================
Files 113 328 +215
Lines 3714 8107 +4393
Branches 965 1279 +314
===========================================
+ Hits 2481 3437 +956
- Misses 1098 4381 +3283
- Partials 135 289 +154
🚀 New features to boost your workflow:
|
fc789e2 to
0121168
Compare
|
Thanks @gajeshbhat. I'll pass it through copilot first and we'll add it to our maintenance review list. As this is not a bug fix, but a new feature with a UI change, we'll also get a UX to review it, to confirm if the approach is good. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "Download Size" column to the channel table in the snap details page, allowing users to see package sizes for each channel to make informed decisions on metered connections.
- Adds a new column displaying download sizes in human-readable format (MB, GB) between Version and Published columns
- Implements size formatting utility function using decimal (1000-based) units
- Includes responsive design hiding the column on mobile/tablet views
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/store/tests_details.py | Adds unit test verifying size data inclusion in channel map and HTML output |
| templates/store/snap-details/_channel_map.html | Updates table header and row template to include Download Size column |
| static/js/public/snap-details/channelMap.ts | Adds size property to interface and formatSize utility function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thank you for taking a look at this @bartaz . Copilot comments were minor, and I have replied to them and likely won't require a code change. No worries about the time, I understand that you folks are busy with higher priority items. Let's also get the clear from UX. Happy to wait. Please feel free to let me know if you have any questions for me. Cheers. |
fb2071d to
a712bb1
Compare
a712bb1 to
719e756
Compare
719e756 to
a1792c4
Compare
f31bad9 to
4a3bcdc
Compare
4a3bcdc to
75449e7
Compare
7ad7d07 to
1463f4d
Compare
|
Hey @bartaz , Hope you have been well. Any chance we can get a review from UI/UX for this PR ? |
938d808 to
6ab966b
Compare
|
Error unrelated to my change: https://github.com/canonical/snapcraft.io/actions/runs/19814162684/job/56761935802?pr=5353 |
53f7e36 to
f8aeb21
Compare
f8aeb21 to
9041f08
Compare
367f80a to
4704eda
Compare
4704eda to
dbff986
Compare
dbff986 to
212a7fc
Compare
212a7fc to
6418e50
Compare
|
Hi there @gajeshbhat! Thank you for the PR and thank you for keeping it up to date with the main branch. I'm sorry but our UX folks are quite busy so it's a bit difficult to get a review from them at the moment. Unlike your other PR, this feature isn't really aligned to our current roadmap so unfortunately it's been falling behind in the review queue. |
Sure. No worries. Let's let this sit here and come back to it when its closer in the Roadmap. |
75d007f to
d4d8c7b
Compare
a59c671 to
72b7ab4
Compare
72b7ab4 to
5868528
Compare
b54e4e0 to
746b60a
Compare
d3bb061 to
ecac31e
Compare
- Add "Download Size" column to channel map table showing per-channel package sizes - Implement human-readable size formatting (B, kB, MB, GB, TB) in JavaScript - Update ChannelData TypeScript interface to include size field - Add responsive design (hidden on mobile screens) - Include comprehensive unit tests for size display functionality Addresses user need for bandwidth awareness on metered connections by showing accurate download sizes for each channel, since different channels can have different package sizes. Fixes canonical#1864
ecac31e to
1ca82a2
Compare
Done
This addresses user need for bandwidth awareness on metered connections by showing accurate download sizes for each channel, since different channels can have different package sizes.
How to QA
feat/show-package-size-1864and run the server locally usingdotrun/firefox,/code,/discord)Testing
test_package_size_in_channel_mapthat verifies size data is correctly included in channel map data structure and HTML outputIssue / Card
Fixes #1864
Screenshots
Screenshots and a screencast have been added below showing the new Download Size column in the channel table across different snap packages.
Screencast of me running the changes locally on a server and Download Sizes column working
Screencast-Downoad-Size-Snapcraft-1864.webm