Skip to content

chore: Add logging for login for SSDLC#5435

Merged
steverydz merged 1 commit intomainfrom
WD-29129-security-event-logging
Oct 23, 2025
Merged

chore: Add logging for login for SSDLC#5435
steverydz merged 1 commit intomainfrom
WD-29129-security-event-logging

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Oct 23, 2025

Done

Adds logging for authentication to satisfy SSDLC requirements

How to QA

  • Run locally
  • Go to http://localhost:8004/snaps whilst logged out
  • Check that in the console you see a warning log with the datetime, event and appid, and a message about failed login
  • Login
  • Check that in the console you see an info log with the datetime, event and appid, and a message about successful login

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-29129

@webteam-app
Copy link
Copy Markdown

@steverydz steverydz force-pushed the WD-29129-security-event-logging branch 2 times, most recently from cbef40f to 207eaf3 Compare October 23, 2025 11:05
@steverydz steverydz changed the title WIP - chore: Add logging for login for SSDLC chore: Add logging for login for SSDLC Oct 23, 2025
@steverydz steverydz marked this pull request as ready for review October 23, 2025 11:18
Copilot AI review requested due to automatic review settings October 23, 2025 11:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds authentication logging to comply with SSDLC security event logging requirements. The changes capture both successful and failed login attempts with structured metadata including timestamps, application ID, and event types.

  • Adds logging statements in the login_required decorator to track authentication events
  • Includes structured metadata (datetime, appid, event) for compliance with SSDLC format requirements
  • Logs failed authentication attempts as warnings and successful logins as info messages

Comment thread webapp/decorators.py Outdated
Comment thread webapp/decorators.py
Comment thread webapp/decorators.py
Comment thread webapp/decorators.py Outdated
@steverydz steverydz force-pushed the WD-29129-security-event-logging branch 3 times, most recently from 0f5aa44 to 4fb9f09 Compare October 23, 2025 13:34
@edisile edisile self-requested a review October 23, 2025 13:50
Comment thread webapp/decorators.py Outdated
Comment thread yarn.lock
@steverydz steverydz force-pushed the WD-29129-security-event-logging branch 2 times, most recently from b3cc007 to 760047d Compare October 23, 2025 14:08
@steverydz steverydz force-pushed the WD-29129-security-event-logging branch from 760047d to 05904e6 Compare October 23, 2025 14:11
Copy link
Copy Markdown
Contributor

@alvaromateo alvaromateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steverydz steverydz merged commit 9520070 into main Oct 23, 2025
13 checks passed
@steverydz steverydz deleted the WD-29129-security-event-logging branch October 23, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants