Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the jsxInJsPlugin from Vite and Vitest configurations, which was a temporary workaround to allow JSX syntax in .js files. The removal is appropriate as all new React component files being added use the .jsx extension.
Key changes:
- Removed the
jsxInJsPluginfunction and its usage fromvite.config.js - Removed the
transformWithEsbuildimport from Vite - Removed the plugin from
vitest.config.jsand its import - Added multiple new React components with proper
.jsxextensions
Reviewed Changes
Copilot reviewed 2 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.js | Removed jsxInJsPlugin function definition and removed it from the plugins array; removed transformWithEsbuild import |
| vitest.config.js | Removed jsxInJsPlugin from plugins array and removed its import |
| static/js/publisher/pages/Releases/releasesController.jsx | New React component for releases controller |
| static/js/publisher/pages/Releases/components/revisionsListRow.jsx | New React component for revision list rows with eslint-disable comment |
| static/js/publisher/pages/Releases/components/revisionsList.jsx | New React component for revisions list with unused import and eslint-disable comment |
| static/js/publisher/pages/Releases/components/revisionLabel.jsx | New React component for revision labels |
| static/js/publisher/pages/Releases/components/releasesTable/*.jsx | Multiple new React components for releases table functionality |
| static/js/publisher/pages/Releases/components/releasesHeading.jsx | New React component for releases heading |
| static/js/publisher/pages/Releases/components/releasesConfirm*.jsx | Multiple new React components for release confirmation UI |
| static/js/publisher/pages/Releases/components/progressive*.jsx | Multiple new React components for progressive release features |
| static/js/publisher/pages/Releases/components/*.jsx | Additional new React components (notification, modal, history, context menu, channel menu, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Renamed .js files that contain JSX and removed the Vite plugin that processes them
How to QA
Testing
Issue / Card
Fixes #
Screenshots