Skip to content

rename .js files that are actually .jsx#5453

Merged
edisile merged 2 commits intomainfrom
rename-js-to-jsx
Nov 11, 2025
Merged

rename .js files that are actually .jsx#5453
edisile merged 2 commits intomainfrom
rename-js-to-jsx

Conversation

@edisile
Copy link
Copy Markdown
Contributor

@edisile edisile commented Nov 7, 2025

Done

Renamed .js files that contain JSX and removed the Vite plugin that processes them

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): just renaming some files

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes the jsxInJsPlugin from Vite and Vitest configurations, which was a temporary workaround to allow JSX syntax in .js files. The removal is appropriate as all new React component files being added use the .jsx extension.

Key changes:

  • Removed the jsxInJsPlugin function and its usage from vite.config.js
  • Removed the transformWithEsbuild import from Vite
  • Removed the plugin from vitest.config.js and its import
  • Added multiple new React components with proper .jsx extensions

Reviewed Changes

Copilot reviewed 2 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.js Removed jsxInJsPlugin function definition and removed it from the plugins array; removed transformWithEsbuild import
vitest.config.js Removed jsxInJsPlugin from plugins array and removed its import
static/js/publisher/pages/Releases/releasesController.jsx New React component for releases controller
static/js/publisher/pages/Releases/components/revisionsListRow.jsx New React component for revision list rows with eslint-disable comment
static/js/publisher/pages/Releases/components/revisionsList.jsx New React component for revisions list with unused import and eslint-disable comment
static/js/publisher/pages/Releases/components/revisionLabel.jsx New React component for revision labels
static/js/publisher/pages/Releases/components/releasesTable/*.jsx Multiple new React components for releases table functionality
static/js/publisher/pages/Releases/components/releasesHeading.jsx New React component for releases heading
static/js/publisher/pages/Releases/components/releasesConfirm*.jsx Multiple new React components for release confirmation UI
static/js/publisher/pages/Releases/components/progressive*.jsx Multiple new React components for progressive release features
static/js/publisher/pages/Releases/components/*.jsx Additional new React components (notification, modal, history, context menu, channel menu, etc.)

@edisile edisile merged commit e02c1e8 into main Nov 11, 2025
19 checks passed
@edisile edisile deleted the rename-js-to-jsx branch November 11, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants