fix: fill the missing data in the metrics response#5479
Merged
Conversation
Demo
Jenkins 
demos.haus 
steverydz
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
edisile
reviewed
Nov 24, 2025
Contributor
edisile
left a comment
edisile
left a comment
There was a problem hiding this comment.
Can't QA because I don't have access to that snap, but code looks good
Comment on lines
+176
to
+178
| while prev_idx >= 0 and prev_value is None: | ||
| prev_value = filled[prev_idx] | ||
| prev_idx -= 1 |
Contributor
There was a problem hiding this comment.
Is there a case where the while is actually necessary? Since we're iterating items in order I think we can assume that the previous spot in the list is not None because it was either a valid number from the start or it has already been filled if it was None...
Contributor
There was a problem hiding this comment.
On second thought not sure if changing it is worth it, I find it's nice that it's symmetrical to the next_value loop
ilayda-cp
added a commit
that referenced
this pull request
Nov 27, 2025
This reverts commit 036ca22.
ilayda-cp
added a commit
that referenced
this pull request
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Sometimes the metrics information that is provided from store API includes None values. This pr fillsout those missing data as follows:
How to QA
Testing
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-15452