Skip to content

TS types for releases API#5490

Merged
edisile merged 5 commits intomainfrom
releases-ui-ts
Nov 28, 2025
Merged

TS types for releases API#5490
edisile merged 5 commits intomainfrom
releases-ui-ts

Conversation

@edisile
Copy link
Copy Markdown
Contributor

@edisile edisile commented Nov 27, 2025 •
edited
Loading

Done

  • added types for releases API payloads and responses
  • removed useless getErrorMessage helper function (all errors were swallowed in the API helpers no the function always returned the same message)
  • fixed a couple of tests that were effectively broken (they used to return responses with "sucess" rather than "success", apparently that didn't count as a failure ¯\(ツ)/¯)

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): just types

Issue / Card

Fixes WD-31604

Screenshots

@webteam-app
Copy link
Copy Markdown

webteam-app commented Nov 27, 2025

Demo

Jenkins

demos.haus

steverydz
steverydz approved these changes Nov 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edisile edisile merged commit 72b19a5 into main Nov 28, 2025
13 checks passed
@edisile edisile deleted the releases-ui-ts branch November 28, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steverydz steverydz steverydz approved these changes

Assignees

No one assigned

Labels

Review: Code +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edisile @webteam-app @steverydz
⚡