Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Remodel section to the publisher Model details area, including a remodels table with search filtering and “Allowed devices” counts derived from policies.
Changes:
- Introduces a new Remodel page/route/tab with a table and search filter.
- Adds
useRemodelshook (with tests) plus Jotai state to filter/enrich remodel entries. - Refactors
getPoliciesto fetch policies by a list of model IDs (instead of full model objects).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| static/js/publisher/utils/getPolicies.ts | Refactors policy fetching to accept modelIds; currently includes debug logging and introduces a breaking signature change. |
| static/js/publisher/types/shared.ts | Adds Remodel type used by the new Remodel feature. |
| static/js/publisher/state/remodelsState.ts | Adds remodel list + filter atoms and derives allowed-device counts from policies. |
| static/js/publisher/pages/Remodel/index.ts | Exposes the Remodel page module entrypoint. |
| static/js/publisher/pages/Remodel/Remodel.tsx | New Remodel page that loads remodels, syncs filter from query string, and triggers policy loading. |
| static/js/publisher/pages/Remodel/RemodelTable.tsx | Renders the remodels table. |
| static/js/publisher/pages/Models/Models.tsx | Updates models page to call getPolicies with modelIds. |
| static/js/publisher/layouts/ModelDetailsPageLayout/ModelPageLayout.tsx | Updates section selection logic to include Remodel. |
| static/js/publisher/layouts/ModelDetailsPageLayout/ModelNav.tsx | Adds Remodel tab to the model navigation. |
| static/js/publisher/index.tsx | Registers the new /remodel route under model details. |
| static/js/publisher/hooks/useRemodels.ts | Adds data-fetching hook for remodel allowlist endpoint. |
| static/js/publisher/hooks/index.ts | Exports useRemodels. |
| static/js/publisher/hooks/tests/useRemodels.test.tsx | Adds tests for useRemodels. |
Contributor
|
@steverydz I've opened a new pull request, #5588, to work on those changes. Once the pull request is ready, I'll request review from you. |
3 tasks
9080706 to
66fe5fb
Compare
66fe5fb to
91c77ef
Compare
edisile
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Adds a remodel tab to the model page with a remodels table and search filter
How to QA
Testing
Security
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-30819
Fixes https://warthogs.atlassian.net/browse/WD-30724
Fixes https://warthogs.atlassian.net/browse/WD-30820
Screenshots
UX Approval