Skip to content

feat: Add remodels table#5587

Merged
steverydz merged 2 commits intomainfrom
WD-30819-create-remodel-table
Feb 12, 2026
Merged

feat: Add remodels table#5587
steverydz merged 2 commits intomainfrom
WD-30819-create-remodel-table

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Feb 11, 2026

Done

Adds a remodel tab to the model page with a remodels table and search filter

How to QA

Testing

  • This PR has tests
  • No testing required (explain why):

Security

  • Security considerations for review (list them):
    • Examples:
    • Access control: users can only access their own data
    • Input: user input is validated and sanitised
    • Sensitive data: secret or private data is not exposed in any way
    • ...
  • This PR has no security considerations (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-30819
Fixes https://warthogs.atlassian.net/browse/WD-30724
Fixes https://warthogs.atlassian.net/browse/WD-30820

Screenshots

UX Approval

  • This PR does not require UX approval (There will be a full UX review when the "Create remodel" form is done)
  • This PR does require UX approval (add context):

@webteam-app
Copy link
Copy Markdown

@steverydz steverydz marked this pull request as ready for review February 11, 2026 16:23
Copilot AI review requested due to automatic review settings February 11, 2026 16:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Remodel section to the publisher Model details area, including a remodels table with search filtering and “Allowed devices” counts derived from policies.

Changes:

  • Introduces a new Remodel page/route/tab with a table and search filter.
  • Adds useRemodels hook (with tests) plus Jotai state to filter/enrich remodel entries.
  • Refactors getPolicies to fetch policies by a list of model IDs (instead of full model objects).

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
static/js/publisher/utils/getPolicies.ts Refactors policy fetching to accept modelIds; currently includes debug logging and introduces a breaking signature change.
static/js/publisher/types/shared.ts Adds Remodel type used by the new Remodel feature.
static/js/publisher/state/remodelsState.ts Adds remodel list + filter atoms and derives allowed-device counts from policies.
static/js/publisher/pages/Remodel/index.ts Exposes the Remodel page module entrypoint.
static/js/publisher/pages/Remodel/Remodel.tsx New Remodel page that loads remodels, syncs filter from query string, and triggers policy loading.
static/js/publisher/pages/Remodel/RemodelTable.tsx Renders the remodels table.
static/js/publisher/pages/Models/Models.tsx Updates models page to call getPolicies with modelIds.
static/js/publisher/layouts/ModelDetailsPageLayout/ModelPageLayout.tsx Updates section selection logic to include Remodel.
static/js/publisher/layouts/ModelDetailsPageLayout/ModelNav.tsx Adds Remodel tab to the model navigation.
static/js/publisher/index.tsx Registers the new /remodel route under model details.
static/js/publisher/hooks/useRemodels.ts Adds data-fetching hook for remodel allowlist endpoint.
static/js/publisher/hooks/index.ts Exports useRemodels.
static/js/publisher/hooks/tests/useRemodels.test.tsx Adds tests for useRemodels.

Comment thread static/js/publisher/hooks/__tests__/useRemodels.test.tsx
Comment thread static/js/publisher/utils/getPolicies.ts Outdated
Comment thread static/js/publisher/types/shared.ts Outdated
Comment thread static/js/publisher/pages/Remodel/Remodel.tsx Outdated
Comment thread static/js/publisher/pages/Remodel/Remodel.tsx Outdated
Comment thread static/js/publisher/pages/Remodel/Remodel.tsx
Comment thread static/js/publisher/pages/Remodel/RemodelTable.tsx
Comment thread static/js/publisher/utils/getPolicies.ts
Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 11, 2026

@steverydz I've opened a new pull request, #5588, to work on those changes. Once the pull request is ready, I'll request review from you.

@steverydz steverydz force-pushed the WD-30819-create-remodel-table branch 2 times, most recently from 9080706 to 66fe5fb Compare February 11, 2026 17:04
@steverydz steverydz force-pushed the WD-30819-create-remodel-table branch from 66fe5fb to 91c77ef Compare February 11, 2026 17:21
@edisile edisile self-requested a review February 12, 2026 11:37
@steverydz steverydz merged commit 6bbc38f into main Feb 12, 2026
14 checks passed
@steverydz steverydz deleted the WD-30819-create-remodel-table branch February 12, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants