Merged
Conversation
Demo
Jenkins 
demos.haus 
steverydz
force-pushed
the
WD-30821-build-configure-remodel-panel
branch
7 times, most recently
from
60e777c to
d29843b
Compare
steverydz
force-pushed
the
WD-30821-build-configure-remodel-panel
branch
2 times, most recently
from
6f3f8fa to
1c1d445
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “Configure remodels” side-panel form to the publisher model remodels page, and updates the remodels table/data fetching to support serial-based remodel allowlist entries for a specific model.
Changes:
- Introduces
ConfigureRemodelFormand routes/remodel/configureto open it in an aside panel with success/error notifications. - Updates remodel list fetching (
useRemodels) to filter remodels to the current model and sort by created date. - Updates remodel table to display serial information and adds pagination/sorting wiring plus tests.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| static/js/publisher/state/remodelsState.ts | Simplifies remodel list state by removing policy-derived “serials” augmentation. |
| static/js/publisher/pages/Remodel/RemodelTable.tsx | Updates columns (Serial) and adds pagination/sorting hook usage. |
| static/js/publisher/pages/Remodel/Remodel.tsx | Adds “Configure remodels” entry point, aside panel rendering, and notifications. |
| static/js/publisher/pages/Remodel/ConfigureRemodelForm.tsx | New form for configuring remodel allowlist entries (target model + serial/all-serials + note) with mutation handling. |
| static/js/publisher/layouts/ModelDetailsPageLayout/ModelPageLayout.tsx | Ensures remodel nav state remains active on /remodel/configure. |
| static/js/publisher/index.tsx | Adds route for remodel/configure. |
| static/js/publisher/hooks/useRemodels.ts | Adds model-scoped filtering and sorts returned remodels. |
| static/js/publisher/hooks/tests/useRemodels.test.tsx | Updates hook tests for new signature. |
| static/js/publisher/pages/Remodel/tests/RemodelTable.test.tsx | Updates expected header label to “Serial”. |
| static/js/publisher/pages/Remodel/tests/ConfigureRemodelForm.test.tsx | Adds tests for basic form enable/disable and serial mode toggle behavior. |
steverydz
force-pushed
the
WD-30821-build-configure-remodel-panel
branch
4 times, most recently
from
d45a6ad to
07bfe20
Compare
|
Reviewed and it looks good to me! |
edisile
approved these changes
Mar 9, 2026
Contributor
edisile
left a comment
edisile
left a comment
There was a problem hiding this comment.
looks good, I only have a very small nitpick
| ): UseQueryResult<RemodelType[], Error> => { | ||
| return useQuery<RemodelType[], Error>({ | ||
| queryKey: ["remodels", brandId], | ||
| model_id: string | undefined, |
Contributor
There was a problem hiding this comment.
super nitpick, but model_id should be renamed to modelId to follow the style convention
|
|
||
| function Remodel(): React.JSX.Element { | ||
| const { id } = useParams(); | ||
| const { id, model_id } = useParams(); |
| setShowErrorNotification, | ||
| setErrorMessage, | ||
| }: Props): React.JSX.Element { | ||
| const { id, model_id } = useParams(); |
Contributor
There was a problem hiding this comment.
since model_id comes from useParams I assume that the route definition should also be changed to modelId
edisile
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: Code needed
Review: QA needed
labels
steverydz
force-pushed
the
WD-30821-build-configure-remodel-panel
branch
from
07bfe20 to
efb04b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Adds a form for users to configure a remodel
How to QA
Testing
Security
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-30821
Screenshots
n/a
UX Approval