Conversation
Demo
Jenkins 
demos.haus 
steverydz
approved these changes
Mar 10, 2026
Contributor
steverydz
left a comment
steverydz
left a comment
There was a problem hiding this comment.
LGTM 👍
Just one small change requested in the code
| <div class="p-code-snippet" style="position: relative;"> | ||
| <pre class="p-code-snippet__block--icon"><code id="snap-install">{{ install_snippet( | ||
| package_name, default_track, lowest_risk_available, confinement) }}</code></pre> | ||
| <button class="u-no-margin--bottom" title="Copy to clipboard" data-js="copy-install-command" data-copy-target="snap-install" data-analytics-click data-analytics-target="snap_details_copy_install_command" data-analytics-channel="{{ default_track }}/{{ lowest_risk_available }}" style="position: absolute; top: 0.5rem; right: 0.5rem; background: transparent; border: none; cursor: pointer; padding: 0.25rem;"><i class="p-icon--copy" style="opacity: 0.7;"></i></button> |
Contributor
There was a problem hiding this comment.
Can you put some text inside the i tags as not all screen readers read out title attributes.
| <div class="p-code-snippet"> | ||
| <div class="p-code-snippet" style="position: relative;"> | ||
| <pre class="p-code-snippet__block--icon is-wrapped"><code id="snap-install-alt">sudo snap install {{ package_name }}${paramString}</code></pre> | ||
| <button class="u-no-margin--bottom" title="Copy to clipboard" data-js="copy-install-command" data-copy-target="snap-install-alt" data-analytics-click data-analytics-target="snap_details_channel_copy_install_command" data-analytics-channel="${channel}" style="position: absolute; top: 0.5rem; right: 0.5rem; background: transparent; border: none; cursor: pointer; padding: 0.25rem;"><i class="p-icon--copy" style="opacity: 0.7;"></i></button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
How to QA
Testing
Security
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-34572
UX Approval